Fix #1648 - ignore authorization in RestInterfaceClient #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I missed the case where the authorization attributes are placed in the interface instead of in the class. But for documentation purposes it would actually be quite nice to place them there. In the long run it would also be nice to extend |
s-ludwig
added a commit
that referenced
this pull request
Feb 2, 2017
|
I commited this now with the mentioned change regarding the if statement and with an additional test. |
s-ludwig
added a commit
that referenced
this pull request
Feb 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the acceptable way to handle REST API with @requiresAuth on the client side, but it seems to solve the problem for me - server side still requires authorization and rest client just ignores this attribute.