Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIET: doctype is actually ignored #505

Closed
nazriel opened this issue Feb 8, 2014 · 2 comments
Closed

DIET: doctype is actually ignored #505

nazriel opened this issue Feb 8, 2014 · 2 comments

Comments

@nazriel
Copy link
Contributor

nazriel commented Feb 8, 2014

If I type:

!!! xml

note
    to Tove
    from Julia

it gets compiled to:

<!DOCTYPE html>
<note>
    <to>Tove</to>
    <from>Julia</from>
</note>

Should be:

<?xml version="1.0" encoding="utf-8" ?>
<note>
  <to>Tove</to>
  <from>Julia</from>
</note>

Also should we allow doctype tag to be alias for !!!?
And how about !!! being deprecated in jade spec?

If you give me green light I can implement it ASAP 👻
@s-ludwig
Copy link
Member

s-ludwig commented Feb 9, 2014

I wouldn't readily deprecate !!!, but adding doctype as an alias may be reasonable to keep the syntax in sync with Jade. Do you know the rationale for that change in Jade, tough?

But support for XML or other HTML doctypes would be very helpful. This would also provide a way to solve #475 in a way that should make everyone happy.

nazriel added a commit to nazriel/vibe.d that referenced this issue Feb 9, 2014
@nazriel
Fix issue vibe-d#505: DIET: doctype is actually ignored
828610d
@nazriel nazriel mentioned this issue Feb 9, 2014
Merged
@nazriel
Copy link
Contributor Author

nazriel commented Feb 9, 2014

Pull request: #509

@s-ludwig I have no idea why they are trying to remove !!!.
I noticed it when playing with demo at http://jade-lang.com/

!!!` is deprecated, you must now use `doctype`

nazriel added a commit to nazriel/vibe.d that referenced this issue Feb 9, 2014
@nazriel
Fix issue vibe-d#505: DIET: doctype is actually ignored
5de0643
s-ludwig added a commit that referenced this issue Feb 9, 2014
@s-ludwig
Merge pull request #509 from nazriel/issue505
7dbaeb8 
Fix issue #505: DIET: doctype is actually ignored
@s-ludwig s-ludwig closed this as completed Feb 9, 2014
nazriel added a commit to nazriel/vibe.d that referenced this issue Feb 10, 2014
@nazriel
Fix issue vibe-d#505: DIET: doctype is actually ignored
e353f4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nazriel @s-ludwig