Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional compilation #1834

Closed
anton-dutov opened this issue Jul 11, 2017 · 4 comments
Closed

Conditional compilation #1834

anton-dutov opened this issue Jul 11, 2017 · 4 comments

Comments

@anton-dutov
Copy link

dub.sdl

dependency "vibe-core"   version="~>1.0.0"
dependency "vibe-d:core" version="~>0.8.0"
dependency "vibe-d:http" version="~>0.8.0"

subConfiguration "vibe-d:core" "vibe-core"

versions "VibeNoSSL"
versions "VibeDefaultMain"

But tls is on?

dub build --build=release
Performing "release" build using dmd for x86_64.
...
diet-ng 1.2.1: building configuration "library"...
vibe-d:crypto 0.8.0: building configuration "library"...
...
vibe-d:diet 0.8.0: building configuration "library"...
...
vibe-d:tls 0.8.0: building configuration "openssl"...
...
  1. How to exclude crypto & tls?
  2. How to exclude diet compilation?
@s-ludwig
Copy link
Member

The way to select the TLS provider has changed (#1823) and now works using configurations:

dependency "vibe-d:tls" version="~>0.8.0"
subConfiguration "vibe-d:tls" "notls"

Crypto can't be excluded, because it's needed for WebSockets and sessions.

Diet is also a fixed dependency, but I just realize now that I should have removed it for 0.8.0, as there is no reason to use it over diet-ng anymore.

s-ludwig added a commit that referenced this issue Jul 11, 2017
@anton-dutov
Copy link
Author

anton-dutov commented Jul 11, 2017

The way to select the TLS provider has changed

Thank you, it works, but docs outdated

Diet is also a fixed dependency, but I just realize now that I should have removed it for 0.8.0, as there is no reason to use it over diet-ng anymore.

May be something version VibeOldDiet, but exclude by default?

@anton-dutov
Copy link
Author

Wow, so fast =)

@s-ludwig
Copy link
Member

Thank you, it works, but docs outdated

Thought the same and am currently working on it :)

May be something version VibeOldDiet, but exclude by default?

By default the dependency isn't used, so this is basically already the case. I've opened a PR to completely remove it. Using VibeOldDiet will then simply output a warning that it has no effect anymore.

s-ludwig added a commit to vibe-d/vibed.org that referenced this issue Jul 11, 2017
s-ludwig added a commit that referenced this issue Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants