Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to kustomzie v3.8.8 #81

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Conversation

devstein
Copy link
Collaborator

@devstein devstein commented Dec 16, 2020

Description

Discovered by #80 the latest release of KSOPS pinned to kustomize v3.9.0 is broken.

I'm going to merge and make a patch release to un-break master, but I'll do a further investigation into why CI passed and what the root of upstream error is.

2020/12/16 12:57:11 Attempting plugin load from '/Users/devstein/.config/kustomize/plugin/viaduct.ai/v1/ksops/ksops.so'
panic: interface conversion: interface {} is string, not map[string]interface {}

goroutine 1 [running]:
sigs.k8s.io/kustomize/api/resmap.getNamespacesForRoleBinding(0xc000c3b7c0, 0x19)
	/Users/devstein/go/pkg/mod/sigs.k8s.io/kustomize/[email protected]/resmap/reswrangler.go:417 +0x352
sigs.k8s.io/kustomize/api/resmap.(*resWrangler).SubsetThatCouldBeReferencedByResource(0xc000311c40, 0xc000c3b7c0, 0xb, 0xc000f45601)
	/Users/devstein/go/pkg/mod/sigs.k8s.io/kustomize/[email protected]/resmap/reswrangler.go:384 +0xdb
sigs.k8s.io/kustomize/api/internal/accumulator.(*nameReferenceTransformer).Transform(0xc0002b4bc0, 0x55648e0, 0xc000311c40, 0xc000311c40, 0x0)
	/Users/devstein/go/pkg/mod/sigs.k8s.io/kustomize/[email protected]/internal/accumulator/namereferencetransformer.go:85 +0x531
sigs.k8s.io/kustomize/api/internal/accumulator.(*ResAccumulator).Transform(...)
	/Users/devstein/go/pkg/mod/sigs.k8s.io/kustomize/[email protected]/internal/accumulator/resaccumulator.go:138
sigs.k8s.io/kustomize/api/internal/accumulator.(*ResAccumulator).FixBackReferences(0xc000311c00, 0xc000311c00, 0x0)
	/Users/devstein/go/pkg/mod/sigs.k8s.io/kustomize/[email protected]/internal/accumulator/resaccumulator.go:164 +0xbe
sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).makeCustomizedResMap(0xc00003c900, 0x0, 0x0, 0x555c980, 0x5fc4f40)
	/Users/devstein/go/pkg/mod/sigs.k8s.io/kustomize/[email protected]/internal/target/kusttarget.go:125 +0x7d
sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).MakeCustomizedResMap(...)
	/Users/devstein/go/pkg/mod/sigs.k8s.io/kustomize/[email protected]/internal/target/kusttarget.go:106
sigs.k8s.io/kustomize/api/krusty.(*Kustomizer).Run(0xc0015cfd20, 0x7ffeefbfefdf, 0x50, 0x0, 0x0, 0x0, 0x0)
	/Users/devstein/go/pkg/mod/sigs.k8s.io/kustomize/[email protected]/krusty/kustomizer.go:77 +0x29b
sigs.k8s.io/kustomize/kustomize/v3/internal/commands/build.(*Options).RunBuild(0xc0008f8620, 0x5507800, 0xc0000ca008, 0x2, 0x0)
	/Users/devstein/go/pkg/mod/sigs.k8s.io/kustomize/kustomize/[email protected]/internal/commands/build/build.go:148 +0xb5
sigs.k8s.io/kustomize/kustomize/v3/internal/commands/build.NewCmdBuild.func1(0xc0006098c0, 0xc000310a80, 0x1, 0x2, 0x0, 0x0)
	/Users/devstein/go/pkg/mod/sigs.k8s.io/kustomize/kustomize/[email protected]/internal/commands/build/build.go:70 +0xad
github.com/spf13/cobra.(*Command).execute(0xc0006098c0, 0xc000310a60, 0x2, 0x2, 0xc0006098c0, 0xc000310a60)
	/Users/devstein/go/pkg/mod/github.com/spf13/[email protected]/command.go:842 +0x47c
github.com/spf13/cobra.(*Command).ExecuteC(0xc000609340, 0x0, 0xffffffff, 0xc0000b8058)
	/Users/devstein/go/pkg/mod/github.com/spf13/[email protected]/command.go:950 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
	/Users/devstein/go/pkg/mod/github.com/spf13/[email protected]/command.go:887
main.main()
	/Users/devstein/go/pkg/mod/sigs.k8s.io/kustomize/kustomize/[email protected]/main.go:19 +0x2a

@devstein devstein self-assigned this Dec 16, 2020
@devstein devstein added the please code review Code review needed label Dec 16, 2020
@devstein
Copy link
Collaborator Author

devstein commented Dec 16, 2020

Reverting the --enable_kyaml flag fixes the error

kustomize build --enable_alpha_plugins  --enable_kyaml=false

@devstein devstein merged commit 63c4844 into master Dec 16, 2020
@devstein devstein deleted the devstein/downgrade-kustomize branch December 16, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please code review Code review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant