Update from Angular 5 to 7 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sijoma
commented
Feb 28, 2019
Sijoma
commented
- In an adventure it is always better to stay on the bleeding edge
- To prevent getting stuck on version 5, I thought it would be a good idea to update to the latest angular version as it can get quite cumbersome to do it later
- Everything seems to work just fine. However, I think it would be good if this PR is carefully checked.
added 7 commits
February 27, 2019 19:14
- edit user details are now translated - viadee#175
- If no free quests are available the new adventure button is disabled - solves(Issue viadee#188)
- In an adventure it is always better to stay on the bleeding edge - Some parts are auto migrated, however everythings seems to work fine
|
Wow, this looks like a major upgrade - I will check it thoroughly before the merge 👍 |
|
Checked it on a fresh installation with Angular 7 - and it seems to work fine! 😋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.