-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades: Golang 1.19, Knative v1.9, K8s v1.25.3, Istio 1.16.0, metallb 0.3.19 #667
Conversation
I've ran the PR branch through the vHive quickstart guide. Looks fine, in the end invoker runs as expected. Should there be any other checks before merge? |
50648bd
to
542a704
Compare
@anshalshukla please fix the linter checks. also, please see the error that poped up in the CRI test. |
c6eb9c0
to
130ba9f
Compare
@anshalshukla please investigate the failing unit test (it probably also causes the CRI tests to fail). Also, please squash your commits that belong to the same logical changes into one using git rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
130ba9f
to
e91a817
Compare
f9018b0
to
eed1a73
Compare
5e0a7c4
to
79dc5cc
Compare
0dbcc0a
to
9dde372
Compare
While trying to test CRI test using this. I face the following error while running
The command eventually ends with a pending external IP for istio-ingressgateway
While this is not the case when the CRI test suite runs via the GitHub actions. See this. On searching for the possible reasons I found a couple of possible reasons for this behaviour. I think the problem is with the scheduling because on running
Also if I run
Then I tried deploying functions which was successful. Here it again differs with the GitHub actions workflow, which failed while function deployment. Eventually on running the cri tests it failed with the following log:
Studying the logs of local testing and GitHub actions I'm unable to pin point the problem. Logs of actions suggest that there is a setup problem with k8s or kn because of which we are unable to deploy functions but locally the k8s and kn seem to be working fine without any error. I tried the same steps with the main branch and although the istio setup completed properly eventually the cri-tests fails with mostly the same errors. |
a935877
to
e8f53b1
Compare
a3724b8
to
2a63d80
Compare
61b7dbf
to
e65fffc
Compare
Signed-off-by: Anshal Shukla <[email protected]>
Signed-off-by: Anshal Shukla <[email protected]>
Signed-off-by: Anshal Shukla <[email protected]>
Signed-off-by: Anshal Shukla <[email protected]>
Signed-off-by: Anshal Shukla <[email protected]>
Signed-off-by: Anshal Shukla <[email protected]>
Signed-off-by: Anshal Shukla <[email protected]>
e65fffc
to
babb981
Compare
23cd1fe
to
c943da8
Compare
6900aed
to
8f6bddf
Compare
|
||
replace github.com/vhive-serverless/vhive/function-images/tests/save_load_minio/proto => ../proto_gen | ||
|
||
require ( | ||
github.com/containerd/containerd v1.4.3 | ||
github.com/vhive-serverless/vhive/function-images/tests/save_load_minio/proto v0.0.0-00010101000000-000000000000 | ||
github.com/containerd/containerd v1.6.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we upgrade this to 1.6.20 without the firecracker-containerd upgrade?
and refactored deprecated API of the dependencies (io/utils) Signed-off-by: Dmitrii Ustiugov <[email protected]>
Signed-off-by: Dmitrii Ustiugov <[email protected]>
Signed-off-by: Dmitrii Ustiugov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready to merge. Thanks a lot to @anshalshukla and @CuriousGeorgiy and the team.
List of upgrades:
WARNING: After this PR, vHive is incompatible with k8s <1.24