change std::system to popen #156
Open
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
reviewed
Jul 23, 2017
lib/MetaProcessor/MetaSema.cpp
Outdated
| std::string command = trimmed.str() + " 2>&1"; | ||
| FILE *shell_result = popen(command.c_str(), "r"); | ||
| if (shell_result) | ||
| { |
There was a problem hiding this comment.
Could you move the brace to the previous line.
lib/MetaProcessor/MetaSema.cpp
Outdated
| { | ||
| char buff[512]; | ||
| ret = 0; | ||
| while(fgets(buff, sizeof(buff), shell_result)!=NULL){ |
There was a problem hiding this comment.
It is more common in cling's codebase to use ! upfront and rely on the implicit bool conversion.
I'd add a space after the brace.
|
@vgvassilev, could you tell me how to build the test suite ? I use |
vgvassilev
reviewed
Jul 24, 2017
lib/MetaProcessor/MetaSema.cpp
Outdated
| char buff[512]; | ||
| ret = 0; | ||
| while(fgets(buff, sizeof(buff), shell_result)!=NULL){ | ||
| bool flag = fgets(buff, sizeof(buff), shell_result) == NULL; |
There was a problem hiding this comment.
What about while(!fgets(buff, sizeof(buff), shell_result))?
|
You should be able to do |
|
@vgvassilev, do I add the test in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the method to execute a shell command in order to control the output stream.
This solves the issue #154