[bugfix] remove erroneous signed param from SAE layer config #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you! sorry for the delay getting this merged |
vgel
added a commit
that referenced
this pull request
Sep 29, 2024
* prototype sae support * fix path * convert to float always * fix index handling * dtype conversion * fix dtype * add sae notebook * [bugfix] remove erroneous signed param from SAE layer config (#47) * remove signed param from SAE layer ocnfig * handle key missing + fmt --------- Co-authored-by: Theia Vogel <[email protected]> --------- Co-authored-by: Max Loeffler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eleuther's SAE library removed the signed param: https://github.com/EleutherAI/sae/pull/23/files#diff-6c69aa3bdde2eab407068f120a5b3eb62e26242fcbccb190a11df2d0dc3aa03bR24
but it's still present in the config files on huggingface. Loading the config with this param doesn't work, so just delete it.