[WIP] Fixes 3737: Add support for AWS Bedrock for ml procedures #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conker84
suggested changes
Oct 19, 2023
| public static final String ALL = "*/*"; | ||
| public static final String JSON = "application/json"; | ||
|
|
||
| enum ModelId { |
There was a problem hiding this comment.
no i modelli li metterei plain string altrimenti poi dobbiamo fare una release ogni volta che ne aggiungono uno nuovo o una nuova versione
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class ModelItemResult { |
There was a problem hiding this comment.
Perché essendoci parecchi parametri, mettendo record credo sia obbligato a mettere un costruttore tutti i parametri, tipo:
public static ModelItemResult from(Map<String, Object> map) {
String modelId = (String) map.get("modelId");
// simile per gli altri
// costruttore con tutti i parametri
return new ModelItemResult(modelId,
modelArn,
modelName,
providerName,
responseStreamingSupported,
customizationsSupported,
inferenceTypesSupported,
inputModalities,
outputModalities);
Con class mi sembra più pulito, facendo semplicemente this.modelName = (String) map.get("modelName");, nel costruttore
| * Similar to JsonUtil.loadJson(..) but works e.g. with GET method as well, | ||
| * for which it would return a FileNotFoundException | ||
| */ | ||
| public static Stream<Object> getModelItemResultStream(String method, HttpClient httpClient, String payloadString, Map<String, Object> headers, String endpoint, String path, List<String> pathOptions) { |
There was a problem hiding this comment.
o gli troviamo un nome generico che non contenga model o lo mettiamo dove stanno le procedure
| /** | ||
| * Mock tests, with local endpoint | ||
| */ | ||
| public class BedrockTest { |
Comment on lines
7
to
8
| CUSTOM("custom-models"), | ||
| FOUNDATION("foundation-models"); |
There was a problem hiding this comment.
anche questi li metterei come stringa per lo stesso motivo dei modelli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~Per evitare di importare sdk di aws, ho creato un file per signature V4: https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-header-based-auth.html. ~
Cambiato con questo, dovrei testarlo.
Bedrock procedures:
ObjectResult:Se l'endpoint non è definito nelle procedure tranne la
.list, viene messo quello di defaulthttps://bedrock-runtime.us-east-1.amazonaws.com/model/<MODEL_ID>/invoke