chore: Use endpoint_type rather than interface to work around lib bug #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also worth noting that CAPO v0.8.0 doesn't work with internal endpoints due to kubernetes-sigs/cluster-api-provider-openstack#1747 |
okozachenko1203
changed the title
okozachenko1203
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our testing against internal API endpoints has found that the use of 'interface' key in the clouds.yaml format doesn't appear to be working, but replacing this with 'endpoint_type' does. Whilst this is likely to be a bug in an underlying component, these appear to suggest that 'endpoint_type' is preferred, so there doesn't seem to be any harm in working around the issue here.
When looking into the underlying bug, we found https://github.com/gophercloud/utils/blob/master/openstack/clientconfig/requests.go#L327, but it isn't clear whether the underlying issue is here or elsewhere.