Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fetch node count from md object when autoscaling enabled #248

Merged
merged 3 commits into from
Nov 16, 2023
Merged

feat: Fetch node count from md object when autoscaling enabled #248

merged 3 commits into from
Nov 16, 2023

Conversation

okozachenko1203
Copy link
Member

No description provided.

@okozachenko1203 okozachenko1203 marked this pull request as draft November 15, 2023 13:18
mnaser
mnaser requested changes Nov 15, 2023
View reviewed changes
magnum_cluster_api/driver.py Outdated Show resolved Hide resolved
@okozachenko1203 okozachenko1203 marked this pull request as ready for review November 15, 2023 13:58
@okozachenko1203
Copy link
Member Author

this has been tested in my local lab with the following step

  • deploy a coe cluster autoscaling enabled with min 2 and max4
  • after the cluster is ready, resize the node count of the default worker nodegroup to 6
  • the md replicas was reset to 2 by capi driver corrrectly
  • the nodegroup replica was retrieved from md replicas by capi driver correctly

@mnaser mnaser merged commit d5548a0 into main Nov 16, 2023
30 checks passed
@mnaser mnaser deleted the fetch-node-count branch November 16, 2023 16:44
@mnaser mnaser mentioned this pull request Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaser mnaser Awaiting requested review from mnaser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okozachenko1203 @mnaser