-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Barbican use same uwsgi config as other services. #1119
Conversation
f682c7a
to
5957c86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two issues with this change
- I have no idea how the CI didn't catch that there wasn't a patch included.. it should have failed because there is a missing patch.
- We either need to push this upstream and add it as a patch into .charts.yml or add it as a local patch.
/cherry-pick stable/zed |
@mnaser: once the present PR merges, I will cherry-pick it on top of stable/zed in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No problem, I was targeting of shift it to upstream once we approve it, but let me link from path now |
b83825c
to
e1c2450
Compare
e1c2450
to
e36bdf6
Compare
e36bdf6
to
5253012
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricolin :
Can you make a follow-up patch similar to these?
8139606
to
0ea151a
Compare
This renew Barbican uwsgi config and make sure it uses same uwsgi config as other services. sync from: https://review.opendev.org/c/openstack/openstack-helm/+/916034
0ea151a
to
c839b46
Compare
@ricolin Since we are actually using backports now and have stable branches, we're trying to avoid bumps on master branch for changes that would be backported (such as this one). We can have another seperate PR for the bump that we would not backport |
recheck |
regate |
2 similar comments
regate |
regate |
regate |
@mnaser: #1119 failed to apply on top of branch "stable/zed":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mnaser: new issue created for failed cherrypick: #1144 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This renew Barbican uwsgi config and make sure it uses same uwsgi config as other services. relate to #42 Reviewed-by: Mohammed Naser <[email protected]>
This renew Barbican uwsgi config and make sure it uses same uwsgi config as other services.
relate to #42