Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added defaultIndex processing for userInput items parsing #23581

Conversation

akolhun
Copy link
Contributor

@akolhun akolhun commented Aug 5, 2022

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@akolhun akolhun changed the title added defaultIndex processing for userInput parsing Added defaultIndex processing for userInput items parsing Aug 5, 2022
Copy link
Member

@bratseth bratseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Since we already access parse-specific state in the superclass I think we should move this there instead of passing it as an argument, but I can do that in a followup PR.

@bratseth bratseth merged commit f4bc347 into vespa-engine:master Aug 15, 2022
@baldersheim
Copy link
Contributor

I suspect this one broke system test https://factory.vespa.oath.cloud/testrun/48700357/test/Alias::test_alias__ELASTIC
Reverting to see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants