Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge limit and full text index scan rule #5577

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Merge limit and full text index scan rule #5577

merged 3 commits into from
Jun 7, 2023

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Jun 6, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Jun 6, 2023
@yixinglu yixinglu marked this pull request as ready for review June 6, 2023 09:28
@Sophie-Xie Sophie-Xie merged commit 209d0bf into vesoft-inc:master Jun 7, 2023
@yixinglu yixinglu deleted the ft-offset branch June 7, 2023 07:22
yixinglu added a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
@Sophie-Xie @cangfengzhs @yixinglu
cherry pick from nebula : full text (guotai junan) (vesoft-inc#2825)
4dff80e 
* Ft search (vesoft-inc#5567)

* Add optimizer rule for pushing limit into the fulltext index scan (vesoft-inc#5575)

* Merge limit and full text index scan rule (vesoft-inc#5577)

* Support to return score from es query (vesoft-inc#5580)

* modify ft search (vesoft-inc#5584)

* modify ft search

* fix bug

* address some comment

* fix bug

* fix conflict

---------

Co-authored-by: hs.zhang <[email protected]>
Co-authored-by: Yee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jievince jievince jievince approved these changes

@cangfengzhs cangfengzhs cangfengzhs approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yixinglu @cangfengzhs @jievince @Sophie-Xie