-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable scan in match. #5416
Enable scan in match. #5416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -39,7 +39,7 @@ class JoinExecutor : public Executor { | |||
size_t colSize_{0}; | |||
// If the join is natural join, rhsOutputColIdxs_ will be used to record the output column index | |||
// of the right. If not, rhsOutputColIdxs_ will be empty. | |||
std::vector<size_t> rhsOutputColIdxs_; | |||
std::optional<std::vector<size_t>> rhsOutputColIdxs_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why to change this field to optional? The original implementation seems OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When |a|
join |a|
will lead to error.
In documentation, we could remove the hacky query example as this issue mentioned also. |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #5399 #5170
Description:
Remove limit requirement of scan in match, e.g. we can run
match (v) return v
directly now.This query failed in CI, but can't reproduce even in
vesoft/nebula-dev:centos7
docker environment. And not caused byScanVertices
so skip it now. Could see detail of this in #5428How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: