Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addSessionCount() in multu-thread case #5393

Merged
merged 4 commits into from
Mar 13, 2023

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Mar 9, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #5392

Description:

When multiple threads try to increment session counts at the same time, there is a chance that emplace() will return false. To avoid this issue, it's recommended to use insert_or_assign instead of emplace because the check for session counts doesn't need to be too strict.

How do you solve it?

Use insert_or_assign instead of emplace.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Aiee Aiee added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected ready for review labels Mar 9, 2023
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xtcyclist xtcyclist merged commit b62168c into vesoft-inc:master Mar 13, 2023
@Aiee Aiee deleted the fix-session-count branch March 13, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert userIpSessionCount to local cache failed
4 participants