Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename the "test" space to "ngdata". #5197

Merged
merged 2 commits into from
Jan 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,8 @@ def load_student_data():
yield load_csv_data_once("student")

@pytest.fixture(scope="session")
def load_test_data():
yield load_csv_data_once("test")
def load_ngdata_data():
yield load_csv_data_once("ngdata")

# TODO(yee): Delete this when we migrate all test cases
@pytest.fixture(scope="class")
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
space:
name: test
name: ngdata
partitionNum: 1
ReplicaFactor: 1
vidType: int
Expand Down
File renamed without changes.
6 changes: 3 additions & 3 deletions tests/tck/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def preload_space(
load_nba_int_vid_data,
load_student_data,
load_ldbc_v0_3_3,
load_test_data,
load_ngdata_data,
exec_ctx,
):
space = normalize_outline_scenario(request, space)
Expand All @@ -194,8 +194,8 @@ def preload_space(
exec_ctx["space_desc"] = load_student_data
elif space == "ldbc_v0_3_3":
exec_ctx["ldbc_v0_3_3"] = load_ldbc_v0_3_3
elif space == "test":
exec_ctx["space_desc"] = load_test_data
elif space == "ngdata":
exec_ctx["space_desc"] = load_ngdata_data
else:
raise ValueError(f"Invalid space name given: {space}")

Expand Down
2 changes: 1 addition & 1 deletion tests/tck/features/expression/Attribute1.feature
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Feature: Attribute using test

Background:
Given load "test" csv data to a new space
Given a graph with space named "ngdata"

Scenario: Attribute with null data
When executing query:
Expand Down
2 changes: 1 addition & 1 deletion tests/tck/features/match/Path.feature
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Feature: Matching paths

Background:
Given load "test" csv data to a new space
Given a graph with space named "ngdata"

Scenario: distinct edges and paths
When executing query:
Expand Down
2 changes: 1 addition & 1 deletion tests/tck/features/optimizer/CasesUsingTestSpace.feature
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Feature: Push Filter Down Cases Using the test Space

Background:
Given load "test" csv data to a new space
Given a graph with space named "ngdata"

Scenario: push filter down hash join bug fix
When profiling query:
Expand Down