Port: remove useless appendVertices below innner/left join #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jievince
commented
Dec 7, 2022
| if (collection_->kind() == Expression::Kind::kLabelTagProperty || | ||
| collection_->kind() == Expression::Kind::kTagProperty) { | ||
| auto v = collection_->eval(ctx); | ||
| result_ = (!v.isNull()) && (!v.empty()); | ||
| return result_; | ||
| } | ||
|
|
There was a problem hiding this comment.
Migrated from nebula-ent.
jievince
force-pushed
the
opt-inner-join
branch
from
7c169ac
to
767cb3f
Compare
yixinglu
reviewed
Dec 7, 2022
| id(friendTeam) AS teamId, | ||
| friendTeam.team.name AS teamName, | ||
| numFriends | ||
| ORDER BY teamName DESC |
There was a problem hiding this comment.
only fix indent of ORDER BY
yixinglu
approved these changes
Dec 7, 2022
yixinglu
changed the title
nevermore3
approved these changes
Dec 7, 2022
czpmango
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: