Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http client ut #4966

Merged
merged 7 commits into from
Dec 1, 2022
Merged

Http client ut #4966

merged 7 commits into from
Dec 1, 2022

Conversation

cangfengzhs
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@cangfengzhs cangfengzhs added the ready-for-testing PR: ready for the CI test label Nov 30, 2022
FakeHttpServer.cpp
)

# nebula_add_executable(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove this, LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codecov-commenter
Copy link

Codecov Report

Base: 76.83% // Head: 76.89% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (cee4b4c) compared to base (7083d72).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4966      +/-   ##
==========================================
+ Coverage   76.83%   76.89%   +0.06%     
==========================================
  Files        1101     1101              
  Lines       81222    81230       +8     
==========================================
+ Hits        62404    62460      +56     
+ Misses      18818    18770      -48     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 92.30% <ø> (ø)
src/storage/CommonUtils.h 98.27% <ø> (ø)
src/storage/exec/QueryUtils.h 90.90% <ø> (ø)
src/storage/CommonUtils.cpp 91.17% <60.00%> (-5.60%) ⬇️
src/graph/context/Result.cpp 70.00% <0.00%> (-10.00%) ⬇️
src/graph/planner/Planner.cpp 75.00% <0.00%> (-5.00%) ⬇️
src/graph/executor/query/ProjectExecutor.cpp 62.16% <0.00%> (-2.71%) ⬇️
src/common/expression/UnaryExpression.cpp 83.69% <0.00%> (-2.18%) ⬇️
src/storage/mutate/AddVerticesProcessor.cpp 86.07% <0.00%> (-2.11%) ⬇️
src/common/expression/LogicalExpression.cpp 91.89% <0.00%> (-1.69%) ⬇️
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@critical27 critical27 merged commit 4f1fe76 into vesoft-inc:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants