Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend white space in unicode. #4959

Merged
merged 7 commits into from
Dec 1, 2022

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Nov 30, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close https://github.com/vesoft-inc/nebula-ent/issues/1714

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Nov 30, 2022
@Shylock-Hg Shylock-Hg added the type/bug Type: something is unexpected label Nov 30, 2022
@codesigner
Copy link
Contributor

codesigner commented Nov 30, 2022

Do we need a tck to cover this?

@Shylock-Hg
Copy link
Contributor Author

Do we need a tck to cover this?

Test in ut.

codesigner
codesigner previously approved these changes Nov 30, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 76.84% // Head: 76.84% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (830a0fc) compared to base (e1a0283).
Patch coverage: 89.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4959      +/-   ##
==========================================
- Coverage   76.84%   76.84%   -0.01%     
==========================================
  Files        1101     1101              
  Lines       81205    81227      +22     
==========================================
+ Hits        62405    62415      +10     
- Misses      18800    18812      +12     
Impacted Files Coverage Δ
src/graph/util/ExpressionUtils.h 100.00% <ø> (ø)
src/graph/util/ExpressionUtils.cpp 94.51% <89.47%> (+0.23%) ⬆️
src/graph/context/Result.cpp 70.00% <0.00%> (-7.78%) ⬇️
src/graph/planner/match/StartVidFinder.cpp 87.50% <0.00%> (-5.84%) ⬇️
...eta/processors/session/SessionManagerProcessor.cpp 73.54% <0.00%> (-4.52%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
src/kvstore/raftex/Host.cpp 69.77% <0.00%> (-2.58%) ⬇️
src/meta/processors/parts/ListHostsProcessor.cpp 70.12% <0.00%> (-2.17%) ⬇️
src/parser/GraphScanner.h 92.63% <0.00%> (-2.00%) ⬇️
src/graph/session/GraphSessionManager.cpp 78.78% <0.00%> (-1.30%) ⬇️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/parser/scanner.lex Outdated Show resolved Hide resolved
@codesigner codesigner merged commit 4d541d1 into vesoft-inc:master Dec 1, 2022
@Shylock-Hg Shylock-Hg deleted the fix/extend-white-space branch December 1, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants