Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the directory structure of the listener #4953

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

panda-sheep
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

  1. Reorganize the directory structure of the listener to facilitate the enterprise version to add other types of listeners.
  2. remove unused variable.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@panda-sheep panda-sheep added ready-for-testing PR: ready for the CI test ready for review and removed ready-for-testing PR: ready for the CI test ready for review labels Nov 29, 2022
@panda-sheep panda-sheep added ready-for-testing PR: ready for the CI test ready for review and removed ready-for-testing PR: ready for the CI test ready for review labels Nov 29, 2022
@Sophie-Xie Sophie-Xie merged commit e1a0283 into vesoft-inc:master Nov 29, 2022
@panda-sheep panda-sheep deleted the improve_listener_structure branch November 29, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants