Ttl read filter #478
Closed
Ttl read filter #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
ayyt
force-pushed
the
TTL_read
branch
2 times, most recently
from
12ce2b6
to
baf77ab
Compare
|
Rebase master and please review code, thx. |
zlcook
reviewed
Jun 4, 2019
src/parser/MaintainSentences.h
Outdated
| return boost::get<std::string>(propValue_); | ||
| } | ||
|
|
||
| bool asBool() { |
There was a problem hiding this comment.
the method seems not be used
zlcook
reviewed
Jun 4, 2019
src/parser/MaintainSentences.h
Outdated
| @@ -76,11 +59,126 @@ class ColumnSpecificationList final { | |||
| }; | |||
|
|
|||
|
|
|||
| class SchemaPropItem final { | |||
| public: | |||
| using Value = boost::variant<int64_t, bool, std::string>; | |||
zlcook
reviewed
Jun 4, 2019
src/parser/MaintainSentences.h
Outdated
| }; | ||
|
|
||
| SchemaPropItem(PropType op, int64_t val) { | ||
| propType_ = op; |
There was a problem hiding this comment.
to make sure that op must be TTL_DURATION here, WDYT?
zlcook
reviewed
Jun 4, 2019
src/parser/MaintainSentences.h
Outdated
| propValue_ = val; | ||
| } | ||
|
|
||
| SchemaPropItem(PropType op, bool val) { |
zlcook
reviewed
Jun 4, 2019
src/graph/test/SchemaTest.cpp
Outdated
| }; | ||
| ASSERT_TRUE(verifyResult(resp, expected)); | ||
| } | ||
| { cpp2::ExecutionResponse resp; |
ayyt
force-pushed
the
TTL_read
branch
2 times, most recently
from
049b3f8
to
4481f13
Compare
Merged
ayyt
force-pushed
the
TTL_read
branch
5 times, most recently
from
29726d8
to
7ac9356
Compare
|
Jenkins go! |
|
Please code review, thx. |
|
Unit testing passed. |
query vertex query edge
|
Unit testing failed. |
yixinglu
added a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
* Fix the column index in lexer. * Add comments. * Fix cases. Co-authored-by: Yee <[email protected]> Co-authored-by: shylock <[email protected]> Co-authored-by: Yee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For vertex and edge with TTL, when reading data, if ttl_duration + ttl_col < now, the data is filtered out.
Close #163