Fix fulltext stopped #4757
Closed
Fix fulltext stopped #4757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperYoko
requested review from
critical27,
jinyingsunny,
pengweisong and
panda-sheep
SuperYoko
commented
Oct 20, 2022
SuperYoko
commented
Oct 20, 2022
| @@ -396,6 +397,9 @@ nebula::cpp2::ErrorCode JobManager::jobFinished( | |||
| } | |||
| // job has been stopped successfully, so update the job status | |||
| return save(jobKey, jobVal); | |||
| } else if (code == nebula::cpp2::ErrorCode::E_JOB_NOT_STOPPABLE) { | |||
| // rollback the job status | |||
| optJobDesc.setStatus(rollbackStatus, true); | |||
There was a problem hiding this comment.
f***k there's risk stop block task report!
There was a problem hiding this comment.
This optJobDesc is a temporary variable. Where to save it?
|
closed since i fix it in wrong way. fixed by #4742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
build ft index is not stopable. while it's status is set to stopped.
and then job executor return "can not stop".
It's running and no new job is allowd.
How do you solve it?
add a check in set status to early return, keep status running.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: