Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats handle the flag use_vertex_key #4738

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

critical27
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Stats handle the flag use_vertex_key:

  1. if off, count vertex by deduplicated tag
  2. if on, count vertex by vertex key

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@critical27 critical27 added ready-for-testing PR: ready for the CI test ready for review cherry-pick-v3.3 PR: need cherry-pick to this version labels Oct 18, 2022
@critical27 critical27 requested a review from a team as a code owner October 18, 2022 11:54
@critical27 critical27 changed the title stats handle the flag use_vertex_key stats handle the flag use_vertex_key, and JobManager Related fix Oct 18, 2022
@Sophie-Xie Sophie-Xie merged commit c144a7a into vesoft-inc:master Oct 19, 2022
@critical27 critical27 changed the title stats handle the flag use_vertex_key, and JobManager Related fix stats handle the flag use_vertex_key Oct 19, 2022
@critical27 critical27 deleted the fix branch October 19, 2022 06:46
caton-hpg pushed a commit to caton-hpg/nebula that referenced this pull request Oct 19, 2022
Sophie-Xie added a commit that referenced this pull request Oct 20, 2022
* fix dep of loop in go planner (#4736)

* fix inappropriate error code from raft (#4737)

Co-authored-by: Sophie <[email protected]>

* Fix variable types collected and graph crash (#4724)

* Fix variable types collected and graph crash

add test cases

small fix

* unskip some test cases related to multiple query parts

* small delete

* fmt

* Fix ldbc BI R5 implementation

Co-authored-by: Harris.Chu <[email protected]>
Co-authored-by: Sophie <[email protected]>

* stats handle the flag use_vertex_key (#4738)

* JobManager related fix (#4742)

Co-authored-by: Sophie <[email protected]>

* download job related fix (#4754)

* fixed case-when error (#4744)

* fixed case-when error

* fix tck

* fix tck

* fix tck

Co-authored-by: Sophie <[email protected]>

* Refine go planner (#4750)

* refine go planner

* update

* fix ctest

Co-authored-by: jie.wang <[email protected]>
Co-authored-by: Doodle <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: Harris.Chu <[email protected]>
Co-authored-by: canon <[email protected]>
@shanlai
Copy link

shanlai commented Oct 24, 2022

3.3.0 rc checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.3 PR: need cherry-pick to this version ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants