-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Early leave findshortestpath loop optimization #4672
Conversation
Add a condition in the loop planner to judge whether there is any independent subgraph of the vids. If it is true, then the loop ends.
@casualwind Thanks for contribution! pls sign the CLA and fix the fail of CI :) |
I have signed the CLA and fix the fail of CI |
@nevermore3 Do you have any time to take a look at this pr? is this blocked by the #4678? is there anything need me to follow up? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
close #4634
Description:
Early leave findshortestpath if the leftvid or the rightvid in a complete divided subgraph without the other one.
Early leave findshortestpath if one the destination vid or start vid doesnot exist.
How do you solve it?
Judge whether newer vids are added in the leftInputVar or the rightInputVar.
add the additional condition in the loop condition.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: