Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix list tag/edge/tagindex/edgeindex #4616

Merged

Conversation

panda-sheep
Copy link
Contributor

@panda-sheep panda-sheep commented Sep 5, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

fix list tag/edge/tagindex/edgeindex logic to display data correctly.
Although it was discovered by the enterprise version, the community version also has the same problem.

list tag/edge/tagindex/edgeindex logic has problems, resulting in display wrong data

The test case is as follows(used for enterprise version):

  1. The master cluster is in the synchronous state at the beginning, do the following:
show sync status;
create tag player1(name string, age int, p3 int, p4 int);
stop sync
  1. Suppose the slave cluster did the following before synchronizing:
create tag index fix on player1(p3);
desc tag index fix
show tag indexes

image

3) The master cluster does the following:

create tag index fix on player1(age);
desc tag index fix
show tag indexes

image

4)Then the master cluster starts synchronization
restart sync
At this time, the following results are displayed from the slave cluster
desc tag index fix
image
The result is displayed correctly

show tag indexes
image

Dirty data is displayed, and the expected result is consistent with the master cluster

close #1236

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

Copy link
Contributor

@wenhaocs wenhaocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@critical27 critical27 merged commit 4b86948 into vesoft-inc:master Sep 7, 2022
@panda-sheep panda-sheep deleted the fix_list_tag/edge/tagindex/edgeindex branch September 7, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants