Minor optimize for go n steps #4566

jievince · 2022-08-22T09:18:02Z

What type of PR is this?

bug
feature
enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Let the n-1 steps inside the loop body of the plan always use GetDstBySrc when don't need to join input for go n stesp.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

Unit test(positive and negative cases)
Function test
Performance test
N/A

Affects:

Documentation affected (Please add the label if documentation needs to be modified.)
Incompatibility (If it breaks the compatibility, please describe it and add the label.）
If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

jievince · 2022-08-22T09:18:52Z

tests/tck/features/go/SimpleCase.feature

+    Then the result should be, in any order, with relax comparison:
+      | count(*) |
+      | 65       |
+    And the execution plan should be:


Before:

-----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | id | name | dependencies | profiling data | operator info | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 12 | Aggregate | 11 | | outputVar: { | | | | | | "colNames": [ | | | | | | "count(*)" | | | | | | ], | | | | | | "name": "__Aggregate_12", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __Project_11 | | | | | | groupKeys: [] | | | | | | groupItems: [ | | | | | | { | | | | | | "expr": "count(*)" | | | | | | } | | | | | | ] | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 11 | Project | 10 | | outputVar: { | | | | | | "colNames": [ | | | | | | "age" | | | | | | ], | | | | | | "name": "__Project_11", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __LeftJoin_10 | | | | | | columns: [ | | | | | | "$__COL_0 AS age" | | | | | | ] | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 10 | LeftJoin | 9 | | outputVar: { | | | | | | "colNames": [ | | | | | | "JOIN_DST_VID", | | | | | | "__COL_0", | | | | | | "DST_VID" | | | | | | ], | | | | | | "name": "__LeftJoin_10", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: { | | | | | | "leftVar": { | | | | | | "__Project_7": 0 | | | | | | }, | | | | | | "rightVar": { | | | | | | "__Project_9": 0 | | | | | | } | | | | | | } | | | | | | hashKeys: [ | | | | | | "COLUMN[-1]" | | | | | | ] | | | | | | probeKeys: [ | | | | | | "COLUMN[-1]" | | | | | | ] | | | | | | kind: LeftJoin | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 9 | Project | 8 | | outputVar: { | | | | | | "colNames": [ | | | | | | "__COL_0", | | | | | | "DST_VID" | | | | | | ], | | | | | | "name": "__Project_9", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __GetVertices_8 | | | | | | columns: [ | | | | | | "$$.player.age AS __COL_0", | | | | | | "COLUMN[0] AS DST_VID" | | | | | | ] | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 8 | GetVertices | 7 | | outputVar: { | | | | | | "colNames": [], | | | | | | "type": "DATASET", | | | | | | "name": "__GetVertices_8" | | | | | | } | | | | | | inputVar: __Project_7 | | | | | | space: 1 | | | | | | dedup: true | | | | | | limit: 9223372036854775807 | | | | | | filter: | | | | | | orderBy: [] | | | | | | src: COLUMN[-1] | | | | | | props: [ | | | | | | { | | | | | | "props": [ | | | | | | "age" | | | | | | ], | | | | | | "tagId": 2 | | | | | | } | | | | | | ] | | | | | | exprs: | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 7 | Project | 6 | | outputVar: { | | | | | | "colNames": [ | | | | | | "JOIN_DST_VID" | | | | | | ], | | | | | | "name": "__Project_7", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __GetNeighbors_6 | | | | | | columns: [ | | | | | | "*._dst AS JOIN_DST_VID" | | | | | | ] | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 6 | GetNeighbors | 5 | | outputVar: { | | | | | | "colNames": [], | | | | | | "type": "DATASET", | | | | | | "name": "__GetNeighbors_6" | | | | | | } | | | | | | inputVar: __VAR_0 | | | | | | space: 1 | | | | | | dedup: false | | | | | | limit: -1 | | | | | | filter: | | | | | | orderBy: [] | | | | | | src: COLUMN[0] | | | | | | edgeTypes: [] | | | | | | edgeDirection: OUT_EDGE | | | | | | vertexProps: | | | | | | edgeProps: [ | | | | | | { | | | | | | "type": -6, | | | | | | "props": [ | | | | | | "_dst" | | | | | | ] | | | | | | }, | | | | | | { | | | | | | "props": [ | | | | | | "_dst" | | | | | | ], | | | | | | "type": 6 | | | | | | } | | | | | | ] | | | | | | statProps: | | | | | | exprs: | | | | | | random: false | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 5 | Loop | 0 | | outputVar: { | | | | | | "colNames": [], | | | | | | "type": "DATASET", | | | | | | "name": "__Loop_5" | | | | | | } | | | | | | inputVar: | | | | | | condition: ((++($__VAR_1)<=2) AND (($__GetNeighbors_2==__EMPTY__) OR (size($__GetNeighbors_2)!=0))) | | | | | | loopBody: 4 | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 4 | Dedup | 3 | | branch: true, nodeId: 5 | | | | | | | | | | | | outputVar: { | | | | | | "colNames": [], | | | | | | "name": "__VAR_0", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __Project_3 | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 3 | Project | 2 | | outputVar: { | | | | | | "colNames": [ | | | | | | "_vid" | | | | | | ], | | | | | | "type": "DATASET", | | | | | | "name": "__Project_3" | | | | | | } | | | | | | inputVar: __GetNeighbors_2 | | | | | | columns: [ | | | | | | "*._dst AS _vid" | | | | | | ] | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 2 | GetNeighbors | 1 | | outputVar: { | | | | | | "colNames": [], | | | | | | "type": "DATASET", | | | | | | "name": "__GetNeighbors_2" | | | | | | } | | | | | | inputVar: __VAR_0 | | | | | | space: 1 | | | | | | dedup: false | | | | | | limit: -1 | | | | | | filter: | | | | | | orderBy: [] | | | | | | src: COLUMN[0] | | | | | | edgeTypes: [] | | | | | | edgeDirection: OUT_EDGE | | | | | | vertexProps: | | | | | | edgeProps: [ | | | | | | { | | | | | | "type": -6, | | | | | | "props": [ | | | | | | "_dst" | | | | | | ] | | | | | | }, | | | | | | { | | | | | | "type": 6, | | | | | | "props": [ | | | | | | "_dst" | | | | | | ] | | | | | | } | | | | | | ] | | | | | | statProps: | | | | | | exprs: | | | | | | random: false | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 1 | Start | | | outputVar: { | | | | | | "colNames": [], | | | | | | "type": "DATASET", | | | | | | "name": "__Start_1" | | | | | | } | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 0 | Start | | | outputVar: { | | | | | | "colNames": [], | | | | | | "name": "__Start_0", | | | | | | "type": "DATASET" | | | | | | } | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------

jievince · 2022-08-22T09:20:10Z

tests/tck/features/go/SimpleCase.feature

+    Then the result should be, in any order, with relax comparison:
+      | count(*) |
+      | 65       |
+    And the execution plan should be:


Before:

-----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | id | name | dependencies | profiling data | operator info | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 8 | Aggregate | 7 | | outputVar: { | | | | | | "colNames": [ | | | | | | "count(*)" | | | | | | ], | | | | | | "name": "__Aggregate_8", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __Project_7 | | | | | | groupKeys: [] | | | | | | groupItems: [ | | | | | | { | | | | | | "expr": "count(*)" | | | | | | } | | | | | | ] | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 7 | Project | 6 | | outputVar: { | | | | | | "colNames": [ | | | | | | "dst" | | | | | | ], | | | | | | "name": "__Project_7", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __GetNeighbors_6 | | | | | | columns: [ | | | | | | "*._dst AS dst" | | | | | | ] | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 6 | GetNeighbors | 5 | | outputVar: { | | | | | | "colNames": [], | | | | | | "type": "DATASET", | | | | | | "name": "__GetNeighbors_6" | | | | | | } | | | | | | inputVar: __VAR_0 | | | | | | space: 1 | | | | | | dedup: false | | | | | | limit: -1 | | | | | | filter: | | | | | | orderBy: [] | | | | | | src: COLUMN[0] | | | | | | edgeTypes: [] | | | | | | edgeDirection: OUT_EDGE | | | | | | vertexProps: | | | | | | edgeProps: [ | | | | | | { | | | | | | "props": [ | | | | | | "_dst" | | | | | | ], | | | | | | "type": -6 | | | | | | }, | | | | | | { | | | | | | "type": 6, | | | | | | "props": [ | | | | | | "_dst" | | | | | | ] | | | | | | } | | | | | | ] | | | | | | statProps: | | | | | | exprs: | | | | | | random: false | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 5 | Loop | 0 | | outputVar: { | | | | | | "colNames": [], | | | | | | "type": "DATASET", | | | | | | "name": "__Loop_5" | | | | | | } | | | | | | inputVar: | | | | | | condition: ((++($__VAR_1)<=2) AND (($__GetNeighbors_2==__EMPTY__) OR (size($__GetNeighbors_2)!=0))) | | | | | | loopBody: 4 | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 4 | Dedup | 3 | | branch: true, nodeId: 5 | | | | | | | | | | | | outputVar: { | | | | | | "colNames": [], | | | | | | "name": "__VAR_0", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __Project_3 | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 3 | Project | 2 | | outputVar: { | | | | | | "colNames": [ | | | | | | "_vid" | | | | | | ], | | | | | | "name": "__Project_3", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __GetNeighbors_2 | | | | | | columns: [ | | | | | | "*._dst AS _vid" | | | | | | ] | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 2 | GetNeighbors | 1 | | outputVar: { | | | | | | "colNames": [], | | | | | | "name": "__GetNeighbors_2", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __VAR_0 | | | | | | space: 1 | | | | | | dedup: false | | | | | | limit: -1 | | | | | | filter: | | | | | | orderBy: [] | | | | | | src: COLUMN[0] | | | | | | edgeTypes: [] | | | | | | edgeDirection: OUT_EDGE | | | | | | vertexProps: | | | | | | edgeProps: [ | | | | | | { | | | | | | "props": [ | | | | | | "_dst" | | | | | | ], | | | | | | "type": -6 | | | | | | }, | | | | | | { | | | | | | "type": 6, | | | | | | "props": [ | | | | | | "_dst" | | | | | | ] | | | | | | } | | | | | | ] | | | | | | statProps: | | | | | | exprs: | | | | | | random: false | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 1 | Start | | | outputVar: { | | | | | | "colNames": [], | | | | | | "type": "DATASET", | | | | | | "name": "__Start_1" | | | | | | } | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 0 | Start | | | outputVar: { | | | | | | "colNames": [], | | | | | | "name": "__Start_0", | | | | | | "type": "DATASET" | | | | | | } | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------

jievince · 2022-08-22T09:21:46Z

tests/tck/features/go/SimpleCase.feature

+    Then the result should be, in any order, with relax comparison:
+      | count(*) |
+      | 10       |
+    And the execution plan should be:


Before:

-----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | id | name | dependencies | profiling data | operator info | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 13 | Aggregate | 12 | | outputVar: { | | | | | | "colNames": [ | | | | | | "count(*)" | | | | | | ], | | | | | | "type": "DATASET", | | | | | | "name": "__Aggregate_13" | | | | | | } | | | | | | inputVar: __Project_12 | | | | | | groupKeys: [] | | | | | | groupItems: [ | | | | | | { | | | | | | "expr": "count(*)" | | | | | | } | | | | | | ] | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 12 | Project | 11 | | outputVar: { | | | | | | "colNames": [ | | | | | | "age" | | | | | | ], | | | | | | "name": "__Project_12", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __Filter_11 | | | | | | columns: [ | | | | | | "$__COL_0 AS age" | | | | | | ] | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 11 | Filter | 10 | | outputVar: { | | | | | | "colNames": [ | | | | | | "JOIN_DST_VID", | | | | | | "__COL_0", | | | | | | "DST_VID" | | | | | | ], | | | | | | "name": "__Filter_11", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __LeftJoin_10 | | | | | | condition: ($__COL_0>36) | | | | | | isStable: false | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 10 | LeftJoin | 9 | | outputVar: { | | | | | | "colNames": [ | | | | | | "JOIN_DST_VID", | | | | | | "__COL_0", | | | | | | "DST_VID" | | | | | | ], | | | | | | "type": "DATASET", | | | | | | "name": "__LeftJoin_10" | | | | | | } | | | | | | inputVar: { | | | | | | "rightVar": { | | | | | | "__Project_9": 0 | | | | | | }, | | | | | | "leftVar": { | | | | | | "__Project_7": 0 | | | | | | } | | | | | | } | | | | | | hashKeys: [ | | | | | | "COLUMN[-1]" | | | | | | ] | | | | | | probeKeys: [ | | | | | | "COLUMN[-1]" | | | | | | ] | | | | | | kind: LeftJoin | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 9 | Project | 8 | | outputVar: { | | | | | | "colNames": [ | | | | | | "__COL_0", | | | | | | "DST_VID" | | | | | | ], | | | | | | "name": "__Project_9", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __GetVertices_8 | | | | | | columns: [ | | | | | | "$$.player.age AS __COL_0", | | | | | | "COLUMN[0] AS DST_VID" | | | | | | ] | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 8 | GetVertices | 7 | | outputVar: { | | | | | | "colNames": [], | | | | | | "type": "DATASET", | | | | | | "name": "__GetVertices_8" | | | | | | } | | | | | | inputVar: __Project_7 | | | | | | space: 1 | | | | | | dedup: true | | | | | | limit: 9223372036854775807 | | | | | | filter: | | | | | | orderBy: [] | | | | | | src: COLUMN[-1] | | | | | | props: [ | | | | | | { | | | | | | "props": [ | | | | | | "age" | | | | | | ], | | | | | | "tagId": 2 | | | | | | } | | | | | | ] | | | | | | exprs: | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 7 | Project | 6 | | outputVar: { | | | | | | "colNames": [ | | | | | | "JOIN_DST_VID" | | | | | | ], | | | | | | "type": "DATASET", | | | | | | "name": "__Project_7" | | | | | | } | | | | | | inputVar: __GetNeighbors_6 | | | | | | columns: [ | | | | | | "*._dst AS JOIN_DST_VID" | | | | | | ] | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 6 | GetNeighbors | 5 | | outputVar: { | | | | | | "colNames": [], | | | | | | "type": "DATASET", | | | | | | "name": "__GetNeighbors_6" | | | | | | } | | | | | | inputVar: __VAR_0 | | | | | | space: 1 | | | | | | dedup: false | | | | | | limit: -1 | | | | | | filter: | | | | | | orderBy: [] | | | | | | src: COLUMN[0] | | | | | | edgeTypes: [] | | | | | | edgeDirection: OUT_EDGE | | | | | | vertexProps: | | | | | | edgeProps: [ | | | | | | { | | | | | | "props": [ | | | | | | "_dst" | | | | | | ], | | | | | | "type": 5 | | | | | | }, | | | | | | { | | | | | | "props": [ | | | | | | "_dst" | | | | | | ], | | | | | | "type": 6 | | | | | | }, | | | | | | { | | | | | | "props": [ | | | | | | "_dst" | | | | | | ], | | | | | | "type": 7 | | | | | | } | | | | | | ] | | | | | | statProps: | | | | | | exprs: | | | | | | random: false | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 5 | Loop | 0 | | outputVar: { | | | | | | "colNames": [], | | | | | | "type": "DATASET", | | | | | | "name": "__Loop_5" | | | | | | } | | | | | | inputVar: | | | | | | condition: ((++($__VAR_1)<=2) AND (($__GetNeighbors_2==__EMPTY__) OR (size($__GetNeighbors_2)!=0))) | | | | | | loopBody: 4 | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 4 | Dedup | 3 | | branch: true, nodeId: 5 | | | | | | | | | | | | outputVar: { | | | | | | "colNames": [], | | | | | | "name": "__VAR_0", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __Project_3 | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 3 | Project | 2 | | outputVar: { | | | | | | "colNames": [ | | | | | | "_vid" | | | | | | ], | | | | | | "name": "__Project_3", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __GetNeighbors_2 | | | | | | columns: [ | | | | | | "*._dst AS _vid" | | | | | | ] | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 2 | GetNeighbors | 1 | | outputVar: { | | | | | | "colNames": [], | | | | | | "name": "__GetNeighbors_2", | | | | | | "type": "DATASET" | | | | | | } | | | | | | inputVar: __VAR_0 | | | | | | space: 1 | | | | | | dedup: false | | | | | | limit: -1 | | | | | | filter: | | | | | | orderBy: [] | | | | | | src: COLUMN[0] | | | | | | edgeTypes: [] | | | | | | edgeDirection: OUT_EDGE | | | | | | vertexProps: | | | | | | edgeProps: [ | | | | | | { | | | | | | "type": 5, | | | | | | "props": [ | | | | | | "_dst" | | | | | | ] | | | | | | }, | | | | | | { | | | | | | "props": [ | | | | | | "_dst" | | | | | | ], | | | | | | "type": 6 | | | | | | }, | | | | | | { | | | | | | "type": 7, | | | | | | "props": [ | | | | | | "_dst" | | | | | | ] | | | | | | } | | | | | | ] | | | | | | statProps: | | | | | | exprs: | | | | | | random: false | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 1 | Start | | | outputVar: { | | | | | | "colNames": [], | | | | | | "name": "__Start_1", | | | | | | "type": "DATASET" | | | | | | } | -----+--------------+--------------+----------------+------------------------------------------------------------------------------------------------------ | 0 | Start | | | outputVar: { | | | | | | "colNames": [], | | | | | | "type": "DATASET", | | | | | | "name": "__Start_0" | | | | | | } |

critical27 · 2022-08-23T04:40:20Z

ctest failed~

jievince · 2022-08-29T03:43:11Z

ctest failed~

ok, I will fix it.

Shylock-Hg · 2022-08-30T03:32:42Z

tests/tck/features/match/SingleShorestPath.feature

@@ -66,34 +66,34 @@ Feature: single shortestPath
      | <("Blake Griffin" :player{age: 30, name: "Blake Griffin"})-[:like@0 {likeness: -1}]->("Chris Paul" :player{age: 33, name: "Chris Paul"})-[:like@0 {likeness: 90}]->("LeBron James" :player{age: 34, name: "LeBron James"})> |
    When executing query:
      """
-      MATCH p = shortestPath( (a:player{age:30})-[e*..5]->(b:team) ) RETURN p
+      MATCH p = shortestPath( (a:player{age:30})-[e*..5]->(b:team) ) RETURN b, length(p)


Why modify this test?

The result of this test is not deterministic, similar to #4431.

This test failed on my local machine. But the change to my pr has nothing to do with the shortest path, and I don't know why I failed the test.

This test failed on my local machine. But the change to my pr has nothing to do with the shortest path, and I don't know why I failed the test.

@nevermore3 Could you help explain it?

i fixed test case in #4583

i fixed test case in #4583

ok, Thanks

critical27 · 2022-09-01T06:04:16Z

Good job~

* Minor fixes and improvements * fix ctest * fix rewriteVertexEdge2EdgeProp * fix fix

jievince commented Aug 22, 2022

View reviewed changes

jievince added the ready-for-testing PR: ready for the CI test label Aug 22, 2022

jievince force-pushed the opt-n-steps branch from a33a655 to 3e7e0fe Compare August 29, 2022 03:42

jievince requested review from nevermore3, Aiee, czpmango and critical27 August 29, 2022 03:42

jievince changed the title ~~Minor fixes and improvements~~ Optimize for go n steps Aug 29, 2022

jievince added 4 commits August 30, 2022 11:17

Minor fixes and improvements

fd8f632

fix ctest

3c06643

fix rewriteVertexEdge2EdgeProp

98bdd27

fix fix

4291c68

jievince force-pushed the opt-n-steps branch from 9d9f567 to 4291c68 Compare August 30, 2022 03:17

Shylock-Hg reviewed Aug 30, 2022

View reviewed changes

Merge branch 'master' into opt-n-steps

e1db26a

nevermore3 approved these changes Aug 31, 2022

View reviewed changes

Merge branch 'master' into opt-n-steps

c39f5e9

jievince requested a review from Shylock-Hg August 31, 2022 09:43

Aiee approved these changes Aug 31, 2022

View reviewed changes

jievince changed the title ~~Optimize for go n steps~~ Minor optimize for go n steps Sep 1, 2022

jievince requested review from dutor, Sophie-Xie and codesigner September 1, 2022 01:46

critical27 merged commit 51d84a4 into vesoft-inc:master Sep 1, 2022

caton-hpg pushed a commit to caton-hpg/nebula that referenced this pull request Sep 1, 2022

Minor optimize for go n steps (vesoft-inc#4566)

952d1ba

* Minor fixes and improvements * fix ctest * fix rewriteVertexEdge2EdgeProp * fix fix

wey-gu mentioned this pull request Sep 3, 2022

Weekly Report 2022-09-02 vesoft-inc/nebula-community#130

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor optimize for go n steps #4566

Minor optimize for go n steps #4566

jievince commented Aug 22, 2022 •

edited

Loading

jievince Aug 22, 2022 •

edited

Loading

jievince Aug 22, 2022

jievince Aug 22, 2022

critical27 commented Aug 23, 2022

jievince commented Aug 29, 2022

Shylock-Hg Aug 30, 2022

jievince Aug 30, 2022

jievince Aug 30, 2022

jievince Aug 30, 2022

nevermore3 Aug 30, 2022 •

edited

Loading

jievince Aug 30, 2022

critical27 commented Sep 1, 2022

Minor optimize for go n steps #4566

Minor optimize for go n steps #4566

Conversation

jievince commented Aug 22, 2022 • edited Loading

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Release notes:

jievince Aug 22, 2022 • edited Loading

Choose a reason for hiding this comment

jievince Aug 22, 2022

Choose a reason for hiding this comment

jievince Aug 22, 2022

Choose a reason for hiding this comment

critical27 commented Aug 23, 2022

jievince commented Aug 29, 2022

Shylock-Hg Aug 30, 2022

Choose a reason for hiding this comment

jievince Aug 30, 2022

Choose a reason for hiding this comment

jievince Aug 30, 2022

Choose a reason for hiding this comment

jievince Aug 30, 2022

Choose a reason for hiding this comment

nevermore3 Aug 30, 2022 • edited Loading

Choose a reason for hiding this comment

jievince Aug 30, 2022

Choose a reason for hiding this comment

critical27 commented Sep 1, 2022

jievince commented Aug 22, 2022 •

edited

Loading

jievince Aug 22, 2022 •

edited

Loading

nevermore3 Aug 30, 2022 •

edited

Loading