Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix when restoring, the machine key is lost #4311

Merged
merged 4 commits into from
Jun 13, 2022

Conversation

panda-sheep
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

fix when restoring, the machine key is lost.
Examples are as follows:

During restore, the mapping relationship of hosts is as follows

211 -> 213
212 -> 212
213 -> 211

When the restore is over, there are only 211, 212, two machine keys left, and the 213 machine key is lost.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@panda-sheep panda-sheep requested review from a team, liwenhui-soul and wenhaocs June 9, 2022 08:26
@Sophie-Xie Sophie-Xie added this to the v3.2.0 milestone Jun 9, 2022
Copy link
Contributor

@pengweisong pengweisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job

@Sophie-Xie Sophie-Xie merged commit 2b35538 into vesoft-inc:master Jun 13, 2022
@panda-sheep panda-sheep deleted the fix_restore branch June 13, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants