-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable DOT in label. #4194
Disable DOT in label. #4194
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4194 +/- ##
========================================
Coverage 84.92% 84.93%
========================================
Files 1328 1329 +1
Lines 131930 132181 +251
========================================
+ Hits 112045 112267 +222
- Misses 19885 19914 +29
Continue to review full report at Codecov.
|
@MuYiYong pls check this incompatible PR, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge after PD review
Talked it with fangyang offline, it's OK.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
Disable DOT character in label, it's meta character in nGQL to represents property lookup.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: