Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable DOT in label. #4194

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Apr 21, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Disable DOT character in label, it's meta character in nGQL to represents property lookup.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

Disable DOT character in label.

@Shylock-Hg Shylock-Hg added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected incompatible PR: incompatible with the recently released version doc affected PR: improvements or additions to documentation labels Apr 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2022

Codecov Report

Merging #4194 (665b7d7) into master (fba3b18) will increase coverage by 0.00%.
The diff coverage is 61.23%.

@@           Coverage Diff            @@
##           master    #4194    +/-   ##
========================================
  Coverage   84.92%   84.93%            
========================================
  Files        1328     1329     +1     
  Lines      131930   132181   +251     
========================================
+ Hits       112045   112267   +222     
- Misses      19885    19914    +29     
Impacted Files Coverage Δ
src/graph/context/Iterator.cpp 87.68% <0.00%> (+0.27%) ⬆️
src/storage/query/QueryBaseProcessor.h 100.00% <ø> (ø)
src/graph/visitor/RewriteVisitor.cpp 61.17% <46.36%> (-15.55%) ⬇️
src/storage/query/QueryBaseProcessor-inl.h 84.63% <70.37%> (+0.31%) ⬆️
src/graph/optimizer/rule/PushEFilterDownRule.cpp 78.78% <78.78%> (ø)
src/graph/executor/query/TraverseExecutor.cpp 95.29% <100.00%> (ø)
src/graph/executor/query/TraverseExecutor.h 100.00% <100.00%> (ø)
src/graph/planner/plan/Query.h 96.24% <100.00%> (+0.02%) ⬆️
src/graph/visitor/RewriteVisitor.h 77.77% <100.00%> (ø)
src/kvstore/raftex/RaftPart.cpp 71.49% <100.00%> (-0.49%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f449f...665b7d7. Read the comment docs.

@Sophie-Xie Sophie-Xie requested a review from MuYiYong April 24, 2022 00:52
@Sophie-Xie
Copy link
Contributor

@MuYiYong pls check this incompatible PR, thanks.

Copy link
Contributor

@Sophie-Xie Sophie-Xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge after PD review

@Sophie-Xie Sophie-Xie added this to the v3.2.0 milestone Apr 25, 2022
@abby-cyber abby-cyber self-assigned this May 27, 2022
@Sophie-Xie Sophie-Xie dismissed their stale review June 7, 2022 06:38

Talked it with fangyang offline, it's OK.

@Sophie-Xie Sophie-Xie merged commit 49f0a51 into vesoft-inc:master Jun 7, 2022
@Shylock-Hg Shylock-Hg deleted the fix/avoid-dot-label branch June 7, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation incompatible PR: incompatible with the recently released version ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants