Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tck compare in order #4149

Merged
merged 20 commits into from
Apr 25, 2022
Merged

fix tck compare in order #4149

merged 20 commits into from
Apr 25, 2022

Conversation

HarrisChu
Copy link
Contributor

  1. fix compare in order, using _compate_order_list
  2. fix typo
  3. change the first {n:d} records in order with Equal type.

@HarrisChu HarrisChu added the ready-for-testing PR: ready for the CI test label Apr 13, 2022
Aiee
Aiee previously approved these changes Apr 13, 2022
czpmango
czpmango previously approved these changes Apr 13, 2022
Copy link
Contributor

@czpmango czpmango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

yixinglu
yixinglu previously approved these changes Apr 13, 2022
@HarrisChu HarrisChu added the wip Solution: work in progress label Apr 13, 2022
@HarrisChu
Copy link
Contributor Author

hold on, there're some option match case should be fixed.

@HarrisChu HarrisChu dismissed stale reviews from yixinglu, czpmango, and Aiee via 2e50836 April 13, 2022 13:49
@HarrisChu HarrisChu removed the wip Solution: work in progress label Apr 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #4149 (a25bc9c) into master (365ad83) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4149      +/-   ##
==========================================
+ Coverage   84.85%   84.92%   +0.06%     
==========================================
  Files        1319     1319              
  Lines      131087   131087              
==========================================
+ Hits       111232   111322      +90     
+ Misses      19855    19765      -90     
Impacted Files Coverage Δ
...eta/processors/session/SessionManagerProcessor.cpp 73.54% <0.00%> (-4.52%) ⬇️
src/storage/exec/QueryUtils.h 93.04% <0.00%> (-1.65%) ⬇️
src/storage/mutate/AddEdgesProcessor.cpp 59.20% <0.00%> (-1.54%) ⬇️
src/kvstore/RocksEngine.h 83.09% <0.00%> (-1.41%) ⬇️
src/graph/session/GraphSessionManager.cpp 78.78% <0.00%> (-1.30%) ⬇️
src/kvstore/raftex/RaftPart.cpp 71.06% <0.00%> (-1.17%) ⬇️
src/codec/RowReaderWrapper.cpp 79.59% <0.00%> (-0.83%) ⬇️
src/common/base/Status.cpp 53.16% <0.00%> (-0.69%) ⬇️
src/meta/processors/parts/ListHostsProcessor.cpp 72.56% <0.00%> (-0.45%) ⬇️
src/storage/admin/AdminTaskManager.cpp 80.40% <0.00%> (-0.40%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 365ad83...a25bc9c. Read the comment docs.

@HarrisChu HarrisChu requested review from yixinglu and Aiee April 14, 2022 01:36
yixinglu
yixinglu previously approved these changes Apr 14, 2022
CPWstatic
CPWstatic previously approved these changes Apr 14, 2022
czpmango
czpmango previously approved these changes Apr 15, 2022
@HarrisChu HarrisChu dismissed stale reviews from czpmango, CPWstatic, and yixinglu via 2dd4f48 April 15, 2022 10:44
yixinglu
yixinglu previously approved these changes Apr 18, 2022
Aiee
Aiee previously approved these changes Apr 18, 2022
@HarrisChu HarrisChu dismissed stale reviews from Aiee and yixinglu via 9c401b7 April 21, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants