Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some bugs in some cases #3980

Merged
merged 7 commits into from
Mar 25, 2022
Merged

Fix some bugs in some cases #3980

merged 7 commits into from
Mar 25, 2022

Conversation

pengweisong
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

The changes include:

  1. Check alive host and hosts format when list clusters.
  2. Add machine replacing when restore.
  3. Cancel block when backup meta table failed.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@pengweisong pengweisong added the ready-for-testing PR: ready for the CI test label Mar 4, 2022
panda-sheep
panda-sheep reviewed Mar 10, 2022
View reviewed changes
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job！

src/kvstore/NebulaStore.cpp Outdated Show resolved Hide resolved
src/meta/processors/admin/CreateBackupProcessor.cpp Show resolved Hide resolved
src/meta/processors/admin/CreateBackupProcessor.cpp Show resolved Hide resolved
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Mar 21, 2022
liwenhui-soul
liwenhui-soul previously approved these changes Mar 23, 2022
View reviewed changes
@pengweisong
improve br, including:
ccd2bf0 
1. cancel block when  backup meta table failed
2. list cluster info only return alive info, and remove redundant alive agents
3. add machine replacing when store
4. add batch write when restore meta
5. improve restore test
panda-sheep
panda-sheep previously approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ~

critical27
critical27 previously approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@pengweisong pengweisong dismissed stale reviews from critical27 and panda-sheep via 4576d80 March 25, 2022 02:20
@critical27 critical27 merged commit a0bf866 into vesoft-inc:master Mar 25, 2022
@jamieliu1023 jamieliu1023 mentioned this pull request Mar 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 approved these changes

@panda-sheep panda-sheep panda-sheep approved these changes

@liwenhui-soul liwenhui-soul liwenhui-soul left review comments

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pengweisong @critical27 @liwenhui-soul @panda-sheep @Sophie-Xie