Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose rocksdb feature of disabling OS page cache #3890

Merged
merged 4 commits into from
Feb 21, 2022

Conversation

wenhaocs
Copy link
Contributor

@wenhaocs wenhaocs commented Feb 14, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Expose rocksdb option of disabling os page cache.
Since OS page cache may be unstable, this feature is very useful in testing and in some production environment which require all memory controllable.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

Users can now disable the OS page cache and only use block cache and nebula storage cache in shared environment, to avoid interference of the memory footprints between applications.

@wenhaocs wenhaocs requested a review from a team as a code owner February 14, 2022 23:44
@wenhaocs wenhaocs changed the title Haowen/add directio Expose rocksdb feature of disabling OS page cache Feb 14, 2022
@wenhaocs wenhaocs added the ready-for-testing PR: ready for the CI test label Feb 14, 2022
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Sophie-Xie Sophie-Xie merged commit c31b6bf into vesoft-inc:master Feb 21, 2022
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Feb 22, 2022
@wenhaocs wenhaocs deleted the haowen/add_directio branch September 28, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants