Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance login password check #3629

Merged
merged 6 commits into from
Jan 6, 2022
Merged

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Jan 4, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:
none
Description:

  1. Remove unnecessary local variables
  2. Substitute std::map with folly::ConcurrentHashMap

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Aiee Aiee added ready-for-testing PR: ready for the CI test ready for review labels Jan 4, 2022
@Aiee Aiee requested a review from cangfengzhs January 5, 2022 02:07
cangfengzhs
cangfengzhs previously approved these changes Jan 5, 2022
Copy link
Contributor

@cangfengzhs cangfengzhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aiee Aiee added cherry-pick-v3.0 PR: need cherry-pick to this version type/bug Type: something is unexpected labels Jan 5, 2022
@Aiee Aiee requested a review from darionyaphet January 5, 2022 06:34
darionyaphet
darionyaphet previously approved these changes Jan 5, 2022
Copy link
Contributor

@darionyaphet darionyaphet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ~

Copy link
Contributor

@darionyaphet darionyaphet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@yixinglu yixinglu merged commit 71f66e9 into vesoft-inc:master Jan 6, 2022
@Aiee Aiee deleted the fix-login-check branch January 6, 2022 04:48
Sophie-Xie pushed a commit that referenced this pull request Jan 10, 2022
critical27 added a commit that referenced this pull request Jan 10, 2022
* Fix typos (#3615)

Co-authored-by: kyle.cao <[email protected]>

* fix fetch edges tostring (#3613)

Co-authored-by: Sophie <[email protected]>
Co-authored-by: Yichen Wang <[email protected]>

* fix create space assign offline host (#3583)

* fix create space

* fix test case

Co-authored-by: Harris.Chu <[email protected]>

* Disable ARM version docker image since related third party not ready (#3618)

* Unify raft error code (#3620)

* Meta upgrader v3 (#3540)

* Replace group when create space

* Support white list

* fix test case

* support zone operations

* fix

* Support meta upgrade v3

* add more check about parse host result (#3628)

* Ut fix (#3611)

* Enable ut and fix chaindelete

* Add mock server default worker

* fix service crash (#3616)

* Cleanup branch param in package script (#3622)

* fix crash when the expression exceed the depth (#3606)

* Enhance login password check (#3629)

* fix_batch_insert_problem (#3627)

* filter data before batch insert

* add test cases

* add more testcase

* add notifyStop() for metaClient (#3621)

* add notifyStop() for metaClient

* do clean

* Fix removeSession() (#3651)

Co-authored-by: Yee <[email protected]>

* Issue3373 storage exit crash (#3553)

* use rcu replace thread local

fix storage exit crash

format

address some comment

* fix bug

* fix bug

* Fix coalesce bug (#3653)

* fix coalesce

* fix test

* add test

* add tck

* fix

* fix

* fix

* delete double check agg in where clause (#3647)

Co-authored-by: Yee <[email protected]>
Co-authored-by: cpw <[email protected]>

* fix meta crash after create space (#3660)

Co-authored-by: Yichen Wang <[email protected]>

Co-authored-by: Yichen Wang <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: jimingquan <[email protected]>
Co-authored-by: yaphet <[email protected]>
Co-authored-by: Harris.Chu <[email protected]>
Co-authored-by: Yee <[email protected]>
Co-authored-by: Doodle <[email protected]>
Co-authored-by: Alex Xing <[email protected]>
Co-authored-by: endy.li <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: hs.zhang <[email protected]>
Co-authored-by: jakevin <[email protected]>
Co-authored-by: cpw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.0 PR: need cherry-pick to this version ready for review ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants