disable an unstable test case #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jievince
previously approved these changes
Dec 29, 2021
darionyaphet
previously approved these changes
Dec 29, 2021
yixinglu
reviewed
Dec 29, 2021
| @@ -219,64 +219,60 @@ TEST(ChainDeleteEdgesTest, Test4) { | |||
| std::this_thread::sleep_for(std::chrono::milliseconds(300)); | |||
| } | |||
|
|
|||
| // add some edges, then delete one of them, not execute local commit | |||
| TEST(ChainDeleteEdgesTest, Test5) { | |||
There was a problem hiding this comment.
use DISABLE_Test5 to disable this test case
liuyu85cn
dismissed stale reviews from darionyaphet and jievince
via
5b7a027
yixinglu
approved these changes
Dec 29, 2021
| @@ -271,9 +236,9 @@ TEST(ChainDeleteEdgesTest, Test5) { | |||
| FakeInternalStorageClient::hookInternalStorageClient(env, iClient); | |||
| ChainResumeProcessor resumeProc(env); | |||
| resumeProc.process(); | |||
| // std::this_thread::sleep_for(std::chrono::milliseconds()); | |||
There was a problem hiding this comment.
why don't remove directly?
There was a problem hiding this comment.
This PR is just for not cause other CI failed. Will dig more until it stable.
Thus it will have some debug code. Not sure if this is the unstable point.
There was a problem hiding this comment.
You could convert it to a draft PR.
critical27
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
It is reported some CI failed of chain_delete_test.Test5
can't repro on 211, just disable it for a while.
(It is weird that test5 and test6 is almost same... why test 6 not failed???)
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: