Spw/refactor br #3469
Merged
Spw/refactor br #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #3469 +/- ##
==========================================
- Coverage 85.40% 85.20% -0.21%
==========================================
Files 1289 1303 +14
Lines 119798 121492 +1694
==========================================
+ Hits 102317 103515 +1198
- Misses 17481 17977 +496
Continue to review full report at Codecov.
|
Nivras
reviewed
Dec 17, 2021
Nivras
reviewed
Dec 17, 2021
Nivras
reviewed
Dec 17, 2021
Nivras
reviewed
Dec 17, 2021
Nivras
reviewed
Dec 17, 2021
Nivras
reviewed
Dec 17, 2021
Nivras
reviewed
Dec 17, 2021
SuperYoko
reviewed
Dec 17, 2021
SuperYoko
reviewed
Dec 17, 2021
pengweisong
force-pushed
the
spw/refactor-br
branch
from
c8d04b9
to
0d497a0
Compare
stash add datapath/rootpath in heartbeat && modify list cluster processor store dir info by address group snapshot rpc call in one host fix snapshot parameter bug fix canocial path bug decrease lastUpdateTime not found info log level stats init && options copy rename ndoe to service rename create backup fields first runnable version rename include system spaces add balance thrift resolve resolve conflicts fix test modify tests remove unrelated lines remove unralted files fix create backup test add some comments & fix list cluster test only report dir info once improve code add agent hb processor test && fix comments fix copy right and log add copyright tidy the create checkpoint rpc stash add datapath/rootpath in heartbeat && modify list cluster processor store dir info by address group snapshot rpc call in one host fix snapshot parameter bug fix canocial path bug decrease lastUpdateTime not found info log level stats init && options copy rename ndoe to service rename create backup fields first runnable version rename include system spaces add balance thrift resolve resolve conflicts fix test modify tests remove unrelated lines remove unralted files fix create backup test add some comments & fix list cluster test only report dir info once improve code add agent hb processor test && fix comments fix copy right and log add copyright
pengweisong
force-pushed
the
spw/refactor-br
branch
from
0d497a0
to
04896c3
Compare
critical27
approved these changes
Dec 23, 2021
Nivras
approved these changes
Dec 23, 2021
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
stash add datapath/rootpath in heartbeat && modify list cluster processor store dir info by address group snapshot rpc call in one host fix snapshot parameter bug fix canocial path bug decrease lastUpdateTime not found info log level stats init && options copy rename ndoe to service rename create backup fields first runnable version rename include system spaces add balance thrift resolve resolve conflicts fix test modify tests remove unrelated lines remove unralted files fix create backup test add some comments & fix list cluster test only report dir info once improve code add agent hb processor test && fix comments fix copy right and log add copyright tidy the create checkpoint rpc stash add datapath/rootpath in heartbeat && modify list cluster processor store dir info by address group snapshot rpc call in one host fix snapshot parameter bug fix canocial path bug decrease lastUpdateTime not found info log level stats init && options copy rename ndoe to service rename create backup fields first runnable version rename include system spaces add balance thrift resolve resolve conflicts fix test modify tests remove unrelated lines remove unralted files fix create backup test add some comments & fix list cluster test only report dir info once improve code add agent hb processor test && fix comments fix copy right and log add copyright Co-authored-by: Sophie <[email protected]> Co-authored-by: pengwei.song <[email protected]> Co-authored-by: Sophie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
The original br tools require password-free ssh to each machine which add extra work for users.
This pr's main goal is to remove ssh dependency. To do this, we introduce an agent in each machine.
Then br can handle machines' data through agent's service.
Agent communicate with the meta service through heartbeat. By heartbeat, agent register itself
to meta service and pull the services it should supervise in its host.
The agent: vesoft-inc/nebula-agent#1
The br: vesoft-inc/nebula-br#22
This pr includes:
Which issue(s)/PR(s) this PR relates to?
The agent: vesoft-inc/nebula-agent#1
The br: vesoft-inc/nebula-br#22
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: