-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse diskPartsKey and add unit test #3416
Conversation
d7d87b0
to
9941a85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done
Codecov Report
@@ Coverage Diff @@
## master #3416 +/- ##
==========================================
+ Coverage 85.24% 85.26% +0.02%
==========================================
Files 1278 1278
Lines 119200 119254 +54
==========================================
+ Hits 101608 101684 +76
+ Misses 17592 17570 -22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. LGTM.
What type of PR is this?
What does this PR do?
add functions to parse host, spaceId and path in diskPartsKey, and fix parseDiskPartsSpace().
add unit test for MetaUtilKeys and DiskManager
Which issue(s)/PR(s) this PR relates to?
#3369
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist:
Release notes:
Please confirm whether to reflect in release notes and how to describe: