Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create question template #3385

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Create question template #3385

merged 3 commits into from
Dec 1, 2021

Conversation

Sophie-Xie
Copy link
Contributor

@Sophie-Xie Sophie-Xie commented Dec 1, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Add a question template for easier management

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Dec 1, 2021
Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great template, thanks, Sophie!

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #3385 (e1e5dfb) into master (fe68b0e) will decrease coverage by 0.02%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3385      +/-   ##
==========================================
- Coverage   85.27%   85.24%   -0.03%     
==========================================
  Files        1276     1277       +1     
  Lines      118999   119024      +25     
==========================================
- Hits       101475   101466       -9     
- Misses      17524    17558      +34     
Impacted Files Coverage Δ
src/graph/session/GraphSessionManager.cpp 80.79% <33.33%> (-0.82%) ⬇️
src/common/expression/ContainerExpression.cpp 90.00% <66.66%> (-2.13%) ⬇️
src/graph/executor/admin/ConfigExecutor.cpp 93.84% <90.90%> (-0.70%) ⬇️
src/clients/meta/MetaClient.cpp 75.95% <100.00%> (-0.09%) ⬇️
src/graph/service/GraphFlags.cpp 100.00% <100.00%> (ø)
src/graph/validator/test/YieldValidatorTest.cpp 91.78% <100.00%> (ø)
src/parser/test/ParserTest.cpp 100.00% <100.00%> (ø)
src/meta/processors/parts/GetSpaceProcessor.cpp 60.60% <0.00%> (-18.19%) ⬇️
src/graph/context/Result.cpp 85.00% <0.00%> (-9.45%) ⬇️
src/kvstore/wal/WalFileIterator.cpp 71.00% <0.00%> (-5.00%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c499116...e1e5dfb. Read the comment docs.

@yixinglu yixinglu merged commit ab73b4c into master Dec 1, 2021
@yixinglu yixinglu deleted the question-issue-template branch December 1, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants