Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3371

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Update README.md #3371

merged 2 commits into from
Nov 29, 2021

Conversation

jamieliu1023
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Updated the link to the forum in README.

Which issue(s)/PR(s) this PR relates to?

None.

Special notes for your reviewer, ex. impact of this fix, etc:

The Discussions tab has just been enabled.

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2021

CLA assistant check
All committers have signed the CLA.

@darionyaphet darionyaphet added the ready-for-testing PR: ready for the CI test label Nov 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3371 (036265c) into master (e981c3f) will decrease coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3371      +/-   ##
==========================================
- Coverage   85.23%   84.58%   -0.66%     
==========================================
  Files        1276     1276              
  Lines      119001   118998       -3     
==========================================
- Hits       101436   100649     -787     
- Misses      17565    18349     +784     
Impacted Files Coverage Δ
src/meta/processors/job/AdminJobProcessor.h 0.00% <0.00%> (-100.00%) ⬇️
src/meta/processors/job/FlushJobExecutor.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/meta/processors/job/ReportTaskProcessor.h 0.00% <0.00%> (-100.00%) ⬇️
src/meta/processors/job/CompactJobExecutor.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/meta/processors/job/RebuildTagJobExecutor.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/meta/processors/job/RebuildEdgeJobExecutor.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/meta/processors/parts/CreateSpaceAsProcessor.h 0.00% <0.00%> (-100.00%) ⬇️
.../meta/processors/job/ListTagIndexStatusProcessor.h 0.00% <0.00%> (-100.00%) ⬇️
...meta/processors/job/ListEdgeIndexStatusProcessor.h 0.00% <0.00%> (-100.00%) ⬇️
src/meta/processors/job/ReportTaskProcessor.cpp 0.00% <0.00%> (-85.72%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e981c3f...036265c. Read the comment docs.

Copy link
Contributor

@SuperYoko SuperYoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is not proper to put this Discussions link in Getting help

@darionyaphet
Copy link
Contributor

Maybe it is not proper to put this Discussions link in Getting help

otherwise no one can find it

@yixinglu yixinglu merged commit fe68b0e into master Nov 29, 2021
@yixinglu yixinglu deleted the jamieliu1023-patch-1 branch November 29, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants