Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] can't show edge after clone space #3351

Merged
merged 6 commits into from
Nov 26, 2021
Merged

Conversation

liuyu85cn
Copy link
Contributor

@liuyu85cn liuyu85cn commented Nov 25, 2021

What type of PR is this?

  • [X ] bug

What does this PR do?

Fix a bug can't show edge after clone space.

Discussed from forum:

https://discuss.nebula-graph.com.cn/t/topic/6565

@liuyu85cn liuyu85cn changed the title [fix] [fix] can't show edge after clone space Nov 25, 2021
@liuyu85cn liuyu85cn added the ready-for-testing PR: ready for the CI test label Nov 25, 2021
panda-sheep
panda-sheep previously approved these changes Nov 25, 2021
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, do we need to add test cases?

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #3351 (e23f135) into master (6541438) will decrease coverage by 0.03%.
The diff coverage is 82.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3351      +/-   ##
==========================================
- Coverage   85.31%   85.27%   -0.04%     
==========================================
  Files        1289     1279      -10     
  Lines      120073   118996    -1077     
==========================================
- Hits       102442   101478     -964     
+ Misses      17631    17518     -113     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.cpp 75.66% <ø> (-0.86%) ⬇️
src/clients/meta/MetaClient.h 95.65% <ø> (ø)
src/graph/optimizer/rule/TopNRule.cpp 95.83% <ø> (ø)
src/graph/planner/plan/Admin.cpp 56.14% <0.00%> (-2.05%) ⬇️
src/graph/planner/plan/PlanNode.h 81.25% <ø> (ø)
src/graph/util/ExpressionUtils.h 100.00% <ø> (ø)
src/graph/validator/MaintainValidator.cpp 84.21% <ø> (+1.55%) ⬆️
src/graph/validator/MaintainValidator.h 80.30% <ø> (+4.72%) ⬆️
src/kvstore/raftex/RaftPart.h 98.30% <ø> (ø)
src/meta/MetaServiceHandler.cpp 87.50% <ø> (-0.88%) ⬇️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14d7b4...e23f135. Read the comment docs.

yixinglu
yixinglu previously approved these changes Nov 25, 2021
@yixinglu
Copy link
Contributor

yixinglu commented Nov 25, 2021

should use following commands to format the feature files:

cd /path/to/nebula/tests
make fmt

@yixinglu yixinglu merged commit ddb9ea4 into vesoft-inc:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants