Support Time-to-live in query(syntax) #330
Conversation
ayyt
commented
May 7, 2019
•
ayyt
commented
- support Time-to-live in syntax
- also extend to support other schema options
- improve create/alter edge for using TTL
ayyt
changed the title
|
Can one of the admins verify this patch? |
src/parser/MaintainSentences.h
Outdated
| items_.emplace_back(item); | ||
| } | ||
|
|
||
| std::vector<std::unique_ptr<SchemaOptItem>> getOpt() { |
There was a problem hiding this comment.
How about getOpts() or opts()?
src/parser/MaintainSentences.h
Outdated
| items_.emplace_back(item); | ||
| } | ||
|
|
||
| std::vector<std::unique_ptr<SchemaOptItem>> getOpt() { |
There was a problem hiding this comment.
Returning std::vector<SchemaOptItem*> is more reasonable. WDYT?
src/parser/MaintainSentences.h
Outdated
| @@ -93,18 +244,25 @@ class CreateTagSentence final : public Sentence { | |||
| return columns_->columnSpecs(); | |||
| } | |||
|
|
|||
| std::vector<std::unique_ptr<SchemaOptItem>> getSchemaOpts() { | |||
src/parser/MaintainSentences.h
Outdated
| @@ -197,17 +363,25 @@ class AlterTagSentence final : public Sentence { | |||
| return opts_->alterTagItems(); | |||
| } | |||
|
|
|||
| std::vector<std::unique_ptr<SchemaOptItem>> getSchemaOpts() { | |||
src/parser/parser.yy
Outdated
| } | ||
| ; | ||
|
|
||
| alter_tag_sentence | ||
| : KW_ALTER KW_TAG LABEL alter_tag_opt_list { | ||
| $$ = new AlterTagSentence($3, $4); | ||
| : KW_ALTER KW_TAG LABEL alter_schema_opt_list alter_tag_opt_list { |
There was a problem hiding this comment.
putting alter_tag_opt_list in front of alter_schema_opt_list seems more reasonable.
There was a problem hiding this comment.
refer mysql , the order of alter_tag_opt_list and alter_schema_opt_list doesn't matter
src/parser/test/ParserTest.cpp
Outdated
| } | ||
| { | ||
| GQLParser parser; | ||
| std::string query = "alter TAG womann ttl_duration = 50, ttl_col = age"; |
There was a problem hiding this comment.
The ttl_col property should be time typed property. In order to avoid misunderstanding, using an appropriate property instead of age in the test case.
There was a problem hiding this comment.
I don't think so. 64bit type can set ttl_col
|
Fixed and rebased master, please review, thx. |
|
Close this PR, use new PR #403. |
