-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete the useless target install-all
#3226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will result in executable error when running `sudo make install-all`
yixinglu
added
ready-for-testing
PR: ready for the CI test
doc affected
PR: improvements or additions to documentation
labels
Oct 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #3226 +/- ##
==========================================
+ Coverage 85.24% 85.26% +0.02%
==========================================
Files 1295 1305 +10
Lines 118190 120388 +2198
==========================================
+ Hits 100748 102653 +1905
- Misses 17442 17735 +293
Continue to review full report at Codecov.
|
Aiee
approved these changes
Oct 29, 2021
jievince
approved these changes
Nov 11, 2021
We may need the target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc affected
PR: improvements or additions to documentation
ready-for-testing
PR: ready for the CI test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This target will result in executable error when running
sudo make install-all
and could be replaced withmake install
.introduced in #3195