Bidirectional traverse. #1740
Merged
Bidirectional traverse. #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPWstatic
requested review from
monadbobo,
dangleptr,
dutor,
laura-ding,
Shylock-Hg,
yixinglu,
zhangguoqing and
zlcook
Merged
Shylock-Hg
reviewed
Feb 11, 2020
monadbobo
reviewed
Feb 11, 2020
dangleptr
reviewed
Feb 14, 2020
| @@ -442,10 +453,13 @@ void GoExecutor::stepOut() { | |||
| } | |||
| auto returns = status.value(); | |||
| std::string filterPushdown = ""; | |||
| if (FLAGS_filter_pushdown && isFinalStep() && !isReversely()) { | |||
| if (FLAGS_filter_pushdown && isFinalStep() | |||
| && direction_ == OverClause::Direction::kForward) { | |||
There was a problem hiding this comment.
Currently, filter could be pushed down for all directions traversal
There was a problem hiding this comment.
There is a new pr #1785 to do this, based on this pr.
CPWstatic
force-pushed
the
go_bidirectional
branch
2 times, most recently
from
2153cfa
to
c23a655
Compare
CPWstatic
force-pushed
the
go_bidirectional
branch
from
c23a655
to
8ab536c
Compare
dangleptr
reviewed
Feb 20, 2020
| return 0L; | ||
| } | ||
| } | ||
| return isReversely() ? srcId : dstId; | ||
| return dstId; |
There was a problem hiding this comment.
@whitewum Please note the changes here.
There was a problem hiding this comment.
can anybody tell me:
E.g.1
,
Match (n)-[xx]->(m)
Return id(m)
is
GO FROM n OVER xx YIELD xx._dst
E.g.2
Match (m)<-[xx]-(n)
Return id(n)
is it
GO FROM m REVERSELY OVER xx YIELD xx._dst or xx._src
E.g.3
Match (n)-[xx]-(m)
Return id(m)
is it
GO FROM n BIDIRECT OVER xx YIELD xx._dst
I'm confused several times, and can't get it anymore.
There was a problem hiding this comment.
e.g.2
GO FROM m REVERSELY OVER xx YIELD xx._dst
e.g.3
GO FROM n BIDIRECT OVER xx YIELD xx._dst
You can think the "_src" represents myself, "_dst" means the other point.
jude-zhu
pushed a commit
to jude-zhu/nebula
that referenced
this pull request
Mar 4, 2020
* Support bidirectional traverse. * Add basic bidirectional traverse test. * Fix ut. * Add ut for multi edge traverse. * Fix clang compile error. * Address comment. * Adddress @dangleptr's comment. * Address comment. Co-authored-by: laura-ding <[email protected]>
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Support bidirectional traverse. * Add basic bidirectional traverse test. * Fix ut. * Add ut for multi edge traverse. * Fix clang compile error. * Address comment. * Adddress @dangleptr's comment. * Address comment. Co-authored-by: laura-ding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1570 #1600 #1609 #1358
I will close #1694, if this is an accepted solution.