Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A syntax sugar for going bidirectional. #1641

Closed
wants to merge 4 commits into from
Closed

A syntax sugar for going bidirectional. #1641

wants to merge 4 commits into from

Conversation

CPWstatic
Copy link
Contributor

@CPWstatic CPWstatic commented Jan 16, 2020 •
edited
Loading

In progress...

#1570 #1600 #1609

after #1471

Need add some UTs, doing...

dangleptr
dangleptr reviewed Jan 17, 2020
View reviewed changes
src/parser/parser.yy
goBackward->setYieldClause(yield);
}

$$ = new SetSentence(goForward, SetSentence::UNION, goBackward);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unbelievable.....

@amber-moe amber-moe self-assigned this Jan 19, 2020
@amber-moe
Copy link
Contributor

Thanks for the effort, will update doc once the code is ready.

@CPWstatic CPWstatic added the ready-for-testing PR: ready for the CI test label Jan 19, 2020
@CPWstatic CPWstatic closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangleptr dangleptr dangleptr left review comments

Assignees

@amber-moe amber-moe

Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CPWstatic @amber-moe @dangleptr