Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[subgraph]if the edge type in where does not exist in the specified Edge type, the error message unclear #4766

Closed
nebula-bots opened this issue Oct 20, 2022 · 0 comments · Fixed by #4941
Closed

[subgraph]if the edge type in where does not exist in the specified Edge type, the error message unclear #4766

nebula-bots opened this issue Oct 20, 2022 · 0 comments · Fixed by #4941
Assignees
@codesigner
Labels
auto-sync severity/trivial Severity of bug type/enhancement Type: make the code neat or more efficient
Milestone
v3.4.0

Comments

@nebula-bots
Copy link
Contributor

Your Environments (required)

(root@nebula) [(none)]> show hosts graph
+-----------------+------+----------+---------+--------------+---------+
| Host            | Port | Status   | Role    | Git Info Sha | Version |
+-----------------+------+----------+---------+--------------+---------+
| "192.168.15.8"  | 9669 | "ONLINE" | "GRAPH" | "cf152be"    | "3.3.0" |
| "192.168.15.9"  | 9669 | "ONLINE" | "GRAPH" | "cf152be"    | "3.3.0" |
| "192.168.15.10" | 9669 | "ONLINE" | "GRAPH" | "cf152be"    | "3.3.0" |
+-----------------+------+----------+---------+--------------+---------+

How To Reproduce(required)
the edge type like in where does not exist in the specified Edge type,

(root@nebula) [nba]> use nba
Execution succeeded (time spent 499/24965 us)

Thu, 20 Oct 2022 18:40:44 CST

(root@nebula) [nba]> GET SUBGRAPH FROM 'Tim Duncan' both  serve WHERE like.likeness < 90 YIELD vertices as v, edges as e
[ERROR (-1005)]: Storage Error: part: 38, error: E_MUTATE_EDGE_CONFLICT(-3045).

Thu, 20 Oct 2022 18:40:45 CST

Expected behavior
Giving clear hints about errors
@nebula-bots nebula-bots added auto-sync severity/trivial Severity of bug type/enhancement Type: make the code neat or more efficient labels Oct 20, 2022
@Sophie-Xie Sophie-Xie modified the milestones: v3.3.0, v3.4.0 Oct 21, 2022
@wey-gu wey-gu mentioned this issue Oct 22, 2022
Closed
@Sophie-Xie Sophie-Xie modified the milestones: v3.3.0, v3.4.0 Oct 26, 2022
@codesigner codesigner mentioned this issue Nov 28, 2022
Merged
12 tasks
@wey-gu wey-gu mentioned this issue Dec 3, 2022
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Jan 31, 2023
@nebula-bots @codesigner
fix SubGraph edge type in filter does not exist in tranversed edge ty…
229179d 
…pe (vesoft-inc#1767)

## What type of PR is this?
- [x] bug
- [ ] feature
- [ ] enhancement

## What problem(s) does this PR solve?
#### Issue(s) number: 
fix vesoft-inc#4766 

#### Description:

As vesoft-inc#4766 described, query should failed with correct message. Added some check edge type during validation stage.

## How do you solve it?



## Special notes for your reviewer, ex. impact of this fix, design document, etc:



## Checklist:
Tests:
- [x] TCK
- [ ] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [ ] N/A

Affects:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.）
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


## Release notes:

Please confirm whether to be reflected in release notes and how to describe:
> ex. Fixed the bug .....


Migrated from vesoft-inc#4941

Co-authored-by: codesigner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codesigner codesigner

Labels
auto-sync severity/trivial Severity of bug type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging a pull request may close this issue.

fix SubGraph edge type in filter does not exist in tranversed edge type codesigner/nebula
4 participants
@codesigner @nevermore3 @Sophie-Xie @nebula-bots