Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query crash when typo property name #431

Closed
whitewum opened this issue May 24, 2019 · 6 comments
Closed

query crash when typo property name #431

whitewum opened this issue May 24, 2019 · 6 comments
Assignees
Milestone

Comments

@whitewum
Copy link
Contributor

I typo likenessx (but should likeness) and crashed:

nebula> go from 100 over like yield $^[player].name, $$[player].name, like.dst, like.likenessx F0524 18:29:24.830096 28428 NebulaSchemaProvider.cpp:48] Check failed: it != fieldNameIndex.end() Unknown field "likenessx" *** Check failure stack trace: *** @ 0x1b1faed google::LogMessage::Fail() @ 0x1b240fc google::LogMessage::SendToLog() @ 0x1b1f7ed google::LogMessage::Flush() @ 0x1b1ffd9 google::LogMessageFatal::~LogMessageFatal() @ 0x15c2244 nebula::meta::NebulaSchemaProvider::getFieldType() @ 0x11dbd27 nebula::storage::QueryBaseProcessor<>::checkAndBuildContexts() @ 0x11d941d nebula::storage::QueryBaseProcessor<>::process() @ 0x11d511c nebula::storage::StorageServiceHandler::future_getOutBound() @ 0x12092f9 _ZZN6nebula7storage4cpp218StorageServiceSvIf20async_eb_getOutBoundESt10unique_ptrIN6apache6thrift15HandlerCallbackINS1_13QueryResponseEEESt14default_deleteIS8_EERKNS1_19GetNeighborsRequestEENUlvE_clEv @ 0x120e579 ZN5folly14makeFutureWithIZN6nebula7storage4cpp218StorageServiceSvIf20async_eb_getOutBoundESt10unique_ptrIN6apache6thrift15HandlerCallbackINS3_13QueryResponseEEESt14default_deleteISA_EERKNS3_19GetNeighborsRequestEEUlvE_EENSt9enable_ifIXsrNS_8isFutureINS_13invoke_resultIT_JEE4typeEEE5valueESN_E4typeEOSL @ 0x120b68c ZN6apache6thrift6detail2si8async_tmIZN6nebula7storage4cpp218StorageServiceSvIf20async_eb_getOutBoundESt10unique_ptrINS0_15HandlerCallbackINS6_13QueryResponseEEESt14default_deleteISB_EERKNS6_19GetNeighborsRequestEEUlvE_EEvPNS0_15ServerInterfaceES8_INS9_IN5folly9drop_unitINSt9result_ofIFT_vEE4type10value_typeEE4typeEEESC_ISV_EEOSO @ 0x120a355 _ZZN6apache6thrift6detail2si8async_ebIZN6nebula7storage4cpp218StorageServiceSvIf20async_eb_getOutBoundESt10unique_ptrINS0_15HandlerCallbackINS6_13QueryResponseEEESt14default_deleteISB_EERKNS6_19GetNeighborsRe

@dutor
Copy link
Contributor

dutor commented May 24, 2019

Thanks to you users.

At such an infant stage, we are sorry about the confusing and frustrating situations like this. There might be a lot more such errors in terms of typing and schema, on which we are working hard.

Again, appreciated very much.

@laura-ding
Copy link
Contributor

We should remove the unreasonable CHECK in NebulaSchemaProvider

@darionyaphet
Copy link
Contributor

Good catch !

Check property name is existed before execution is a good idea?

@dangleptr
Copy link
Contributor

@darionyaphet Would you want to fix it?

@darionyaphet
Copy link
Contributor

Good ! I will try to fix it ~

@wadeliuyi
Copy link
Contributor

I think this is same with #571, should close it?

critical27 added a commit to critical27/nebula that referenced this issue Apr 2, 2021
yixinglu added a commit that referenced this issue Apr 7, 2021
* cherry pick #431 from 2.0

* cherry pick #424 from 2.0

Co-authored-by: Yee <[email protected]>
tong-hao pushed a commit to tong-hao/nebula that referenced this issue Jun 1, 2021
* cherry pick vesoft-inc#431 from 2.0

* cherry pick vesoft-inc#424 from 2.0

Co-authored-by: Yee <[email protected]>
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants