address comment

vesoft-inc · Apr 12, 2022 · c03e5c8 · c03e5c8
1 parent b4123bf
commit c03e5c8
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/src/graph/executor/algo/BFSShortestPathExecutor.cpp b/src/graph/executor/algo/BFSShortestPathExecutor.cpp
@@ -152,7 +152,8 @@ folly::Future<Status> BFSShortestPathExecutor::conjunctPath() {
   });
 }
 
-DataSet BFSShortestPathExecutor::doConjunct(const std::vector<Value> meetVids, bool oddStep) {
+DataSet BFSShortestPathExecutor::doConjunct(const std::vector<Value>& meetVids,
+                                            bool oddStep) const {
   DataSet ds;
   auto leftPaths = createPath(meetVids, false, oddStep);
   auto rightPaths = createPath(meetVids, true, oddStep);
@@ -171,7 +172,7 @@ DataSet BFSShortestPathExecutor::doConjunct(const std::vector<Value> meetVids, b
 }
 
 std::unordered_multimap<Value, Path> BFSShortestPathExecutor::createPath(
-    std::vector<Value> meetVids, bool reverse, bool oddStep) {
+    std::vector<Value> meetVids, bool reverse, bool oddStep) const {
   std::unordered_multimap<Value, Path> result;
   auto& allEdges = reverse ? allRightEdges_ : allLeftEdges_;
   for (auto& meetVid : meetVids) {

diff --git a/src/graph/executor/algo/BFSShortestPathExecutor.h b/src/graph/executor/algo/BFSShortestPathExecutor.h
@@ -52,11 +52,11 @@ class BFSShortestPathExecutor final : public Executor {
 
   folly::Future<Status> conjunctPath();
 
-  DataSet doConjunct(const std::vector<Value> meetVids, bool oddStep);
+  DataSet doConjunct(const std::vector<Value>& meetVids, bool oddStep) const;
 
   std::unordered_multimap<Value, Path> createPath(std::vector<Value> meetVids,
                                                   bool reverse,
-                                                  bool oddStep);
+                                                  bool oddStep) const;
 
  private:
   const BFSShortestPath* pathNode_{nullptr};

diff --git a/src/graph/executor/algo/ProduceAllPathsExecutor.cpp b/src/graph/executor/algo/ProduceAllPathsExecutor.cpp
@@ -96,7 +96,7 @@ Status ProduceAllPathsExecutor::buildPath(bool reverse) {
 
 DataSet ProduceAllPathsExecutor::doConjunct(Interims::iterator startIter,
                                             Interims::iterator endIter,
-                                            bool oddStep) {
+                                            bool oddStep) const {
   auto& rightPaths = oddStep ? preRightPaths_ : rightPaths_;
   DataSet ds;
   for (; startIter != endIter; ++startIter) {

diff --git a/src/graph/executor/algo/ProduceAllPathsExecutor.h b/src/graph/executor/algo/ProduceAllPathsExecutor.h
@@ -56,7 +56,7 @@ class ProduceAllPathsExecutor final : public Executor {
 
   Status buildPath(bool reverse);
   folly::Future<Status> conjunctPath();
-  DataSet doConjunct(Interims::iterator startIter, Interims::iterator endIter, bool oddStep);
+  DataSet doConjunct(Interims::iterator startIter, Interims::iterator endIter, bool oddStep) const;
   void setNextStepVid(Interims& paths, const string& var);
 
  private: