Skip to content

Commit

Permalink
address @wenhaocs's comments
Browse files Browse the repository at this point in the history
  • Loading branch information
critical27 committed Nov 25, 2022
1 parent 6854203 commit 1538114
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/kvstore/RocksEngine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId,
extractorLen_ = sizeof(PartitionID) + vIdLen;
} else if (factoryName == rocksdb::TableFactory::kPlainTableName()) {
// PlainTable only support prefix-based seek, which means if the prefix is not inserted into
// rocksdb, we can't read them from "prefix" api anymore. For simplarity, we just set the length
// rocksdb, we can't read them from "prefix" api anymore. For simplicity, we just set the length
// of prefix extractor to the minimum length we used in "prefix" api, which is 4 when we seek by
// tagPrefix(partId) or edgePrefix(partId).
isPlainTable_ = true;
Expand Down
2 changes: 1 addition & 1 deletion src/kvstore/RocksEngineConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ rocksdb::Status initRocksdbOptions(rocksdb::Options& baseOpts,
return rocksdb::Status::InvalidArgument("PlainTable should use prefix bloom filter");
}
// PlainTable only support prefix-based seek, which means if the prefix is not inserted into
// rocksdb, we can't read them from "prefix" api anymore. For simplarity, we just set the length
// rocksdb, we can't read them from "prefix" api anymore. For simplicity, we just set the length
// of prefix extractor to the minimum length we used in "prefix" api, which is 4 when we seek by
// tagPrefix(partId) or edgePrefix(partId).
size_t prefixLength = sizeof(PartitionID);
Expand Down

0 comments on commit 1538114

Please sign in to comment.