-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charts update #91
Charts update #91
Conversation
metricsBindAddr: ":8080" | ||
|
||
# The address the probe endpoint binds to. (default: ":8081") | ||
healthProbeBindAddr: ":8081" | ||
|
||
# The TCP port the Webhook server binds to. (default 9443) | ||
webhookBindPort: 9443 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the same format?
@@ -75,7 +75,7 @@ The following table lists is the configurable parameters of the chart and their | |||
| Parameter | Description | Default | | |||
|:---------|:-----------|:-------| | |||
| `nameOverride` | Override the name of the chart | `nil` | | |||
| `nebula.version` | Nebula version | `v2.0.1` | | |||
| `nebula.version` | Nebula version | `v2.6.1` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those now added config in values is not contains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.