Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts update #91

Merged
merged 4 commits into from
Nov 12, 2021
Merged

Charts update #91

merged 4 commits into from
Nov 12, 2021

Conversation

MegaByte875
Copy link
Contributor

No description provided.

@MegaByte875 MegaByte875 requested review from veezhang and kqzh November 11, 2021 12:11
Comment on lines +53 to +59
metricsBindAddr: ":8080"

# The address the probe endpoint binds to. (default: ":8081")
healthProbeBindAddr: ":8081"

# The TCP port the Webhook server binds to. (default 9443)
webhookBindPort: 9443
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the same format?

@@ -75,7 +75,7 @@ The following table lists is the configurable parameters of the chart and their
| Parameter | Description | Default |
|:---------|:-----------|:-------|
| `nameOverride` | Override the name of the chart | `nil` |
| `nebula.version` | Nebula version | `v2.0.1` |
| `nebula.version` | Nebula version | `v2.6.1` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those now added config in values is not contains.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it

Copy link
Contributor

@veezhang veezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veezhang veezhang merged commit 63ed947 into vesoft-inc:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants