Upgrade nebula sdk #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veezhang
reviewed
Nov 11, 2021
pkg/nebula/meta_client.go
Outdated
| "github.com/vesoft-inc/nebula-go/nebula/meta" | ||
| "github.com/vesoft-inc/nebula-go/v2/nebula" | ||
| "github.com/vesoft-inc/nebula-go/v2/nebula/meta" | ||
|
|
There was a problem hiding this comment.
import 4 groups, remove this line?
kqzh
reviewed
Nov 11, 2021
| @@ -13,11 +13,11 @@ spec: | |||
| memory: "1Gi" | |||
| replicas: 1 | |||
| image: vesoft/nebula-graphd | |||
| version: v2.0.1 | |||
| version: v2.5.1 | |||
There was a problem hiding this comment.
update to v2.6.1 with 3 component?
veezhang
reviewed
Nov 12, 2021
pkg/controller/component/pvc_gc.go
Outdated
| for _, pvcName := range pvcNames { | ||
| pvc, err := pvcClient.GetPVC(component.GetNamespace(), pvcName) | ||
| if err != nil { | ||
| return fmt.Errorf("get pvc %s for cluster %s/%s failed: %s", pvcName, component.GetNamespace(), component.GetClusterName(), err) |
There was a problem hiding this comment.
lint: line-length-limit: line is 144 characters, out of limit 140 (revive)
| func ordinalPVCNames(componentType v1alpha1.ComponentType, setName string, ordinal int32) []string { | ||
| logPVC := fmt.Sprintf("%s-log-%s-%d", componentType, setName, ordinal) | ||
| dataPVC := fmt.Sprintf("%s-data-%s-%d", componentType, setName, ordinal) | ||
| if componentType == v1alpha1.GraphdComponentType { |
There was a problem hiding this comment.
May be better combined with GenerateVolumeMounts?
Comment on lines
142
to
143
| _, err = ss.clientSet.PVC().GetPVC(nc.GetNamespace(), pvcName) | ||
| if !apierrors.IsNotFound(err) { |
There was a problem hiding this comment.
- How about other error? For example, network.
if _, err = GetPVC(); condition { ... }- At the end of this function, should return an err to let it re-enter the queue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.