Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example for SessionPool #500

Merged
merged 1 commit into from
Dec 29, 2022
Merged

add example for SessionPool #500

merged 1 commit into from
Dec 29, 2022

Conversation

Nicole00
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close #493

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@codecov-commenter
Copy link

Codecov Report

Base: 63.46% // Head: 63.41% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (81ca163) compared to base (a719bd5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #500      +/-   ##
============================================
- Coverage     63.46%   63.41%   -0.06%     
+ Complexity      787      786       -1     
============================================
  Files            71       71              
  Lines          3758     3758              
  Branches        537      537              
============================================
- Hits           2385     2383       -2     
- Misses         1004     1005       +1     
- Partials        369      370       +1     
Impacted Files Coverage Δ
...va/com/vesoft/nebula/client/graph/SessionPool.java 56.49% <0.00%> (-1.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nicole00 Nicole00 merged commit e25c56d into vesoft-inc:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need session pool example in readme and highlight the differences of connection pool and session pool
3 participants